Bug 268802 - Useless call to getSource() in SourceTypeConverter
Summary: Useless call to getSource() in SourceTypeConverter
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-03-16 10:53 EDT by David Audel CLA
Modified: 2009-04-28 02:37 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (3.12 KB, patch)
2009-03-16 10:55 EDT, David Audel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2009-03-16 10:53:51 EDT 
build I20090311-0100

SourceTypeConverter#convertAnnotations() call SourceTypeConverter#getSource() to create annotation but getSource() is call even when there is no annotation.

getSource() should be call only when necessary.
Comment 1 David Audel CLA 2009-03-16 10:55:07 EDT 
Created attachment 128924 [details]
Proposed fix
Comment 2 David Audel CLA 2009-03-16 11:45:07 EDT 
Released for 3.5M7.
Comment 3 Srikanth Sankaran CLA 2009-04-28 02:37:50 EDT 
Verified for 3.5M7 using I20090426-2000