Community
Participate
Working Groups
Build ID: WTP 3.1 Steps To Reproduce: There is validation, quick fix, and code clean up for NLS strings in JSDT. These are not needed and can be removed. More information:
Created attachment 128725 [details] Removes NLS related code
Updated patch removes the following problems (names from IProblem class): ArgumentIsNeverUsed ArgumentTypeAmbiguous ArgumentTypeCannotBeVoidArray ArgumentTypeInheritedNameHidesEnclosingName ArgumentTypeInternalNameProvided ArgumentTypeNotFound ArgumentTypeNotVisible CorruptedSignature ExceptionTypeAmbiguous ExceptionTypeInheritedNameHidesEnclosingName ExceptionTypeInternalNameProvided ExceptionTypeNotFound ExceptionTypeNotVisible FieldMissingDeprecatedAnnotation ImportAmbiguous ImportInheritedNameHidesEnclosingName ImportInternalNameProvided ImportNotVisible InterfactAmbiguous InterfaceInheritedNameHidesEnclosingName InterfaceInteralNameProvided InterfaceNotFound InterfaceNotVisible InternalTypeNameProvided InvalidTypeforStaticImport JavadocInternalTypeNameProvided JavadocTypeArgumentsForRawGenericConstructor LocalVairableCannotBeNull LocalVariableCanOnlyBeNull LocalVariableMayBeNull MethodMissingDeprecatedAnnotation MissingOverrideAnnotaiton NativeMethodsCannotBeStrictfp NonEternalizedStringLiteral ObjectCannotBeGeneric ObjectCanotHaveSuperTypes ObjectHasNoSuperclass ObjectMustBeClass ReturnTypeAmbiguous ReturnTypeCannotBeVoidArray ReturnTypeInheritedNameHidesEnclosingName ReturnTypeInheritedNameProvided ReturnTypeNotFound ReturnTypeNotVisible SuperclassAmbiguous SuperclassInheritedNameHidesEnclosingName SuperclassInternalNameProvided SuperclassNotFound SuperclassNotVisible TypeMissingDeprecatedAnnotaiton UnnecessaryNLSTag UnusedConstructorDeclaredThrownException UnusedMethodDeclaredThrownException VariableTypeCannotBeVoidArray
Created attachment 128978 [details] Removes unused Problems
Created attachment 130703 [details] Removes unused validation problems
Problems removed: IProblem.JavadocTypeArgumentsForRawGenericConstructor IProblem.JavadocParameterizedConstructorArgumentTypeMismatch IProblem.JavadocIncorrectArityForParameterizedConstructor IProblem.JavadocNonGenericConstructor IProblem.JavadocGenericConstructorTypeArgumentMismatch IProblem.JavadocTypeArgumentsForRawGenericMethod IProblem.JavadocParameterizedMethodArgumentTypeMismatch IProblem.JavadocNonGenericMethod IProblem.JavadocGenericMethodTypeArgumentMismatch IProblem.VarargsConflict IProblem.ConstructorVarargsArgumentNeedCast IProblem.MethodVarargsArgumentNeedCast IProblem.IllegalExtendedDimensionsForVarArgs IProblem.EnumStaticFieldInInInitializerContext IProblem.MissingEnumConstantCase IProblem.IllegalModifierForEnumConstructor IProblem.EnumSwitchCannotTargetField IProblem.CannotInvokeSuperConstructorInEnum IProblem.EnumAbstractMethodMustBeImplemented IProblem.CannotExtendEnum IProblem.CannotDeclareEnumSpecialMethod IProblem.IllegalQualifiedEnumConstantLabel IProblem.IllegalModifierForLocalEnum IProblem.IllegalModifierForMemberEnum IProblem.IllegalModifierForEnum IProblem.IllegalModifierForEnumConstant
Created attachment 131032 [details] More problems removed
The latest patch added(patchFor268542_4) removes all the problems listed in comment #5 as well as those listed here... IProblem.MethodMustOverrideOrImplement IProblem.AnnotationValueMustBeAnEnumConstant IProblem.AnnotationValueMustBeArrayInitializer IProblem.UnhandledWarningToken IProblem.FieldMissingDeprecatedAnnotation IProblem.MethodMissingDeprecatedAnnotation IProblem.TypeMissingDeprecatedAnnotation IProblem.MissingOverrideAnnotation IProblem.AnnotationTypeUsedAsSuperInterface IProblem.AnnotationValueMustBeAnnotation IProblem.AnnotationTypeDeclarationCannotHaveConstructor IProblem.MethodMustOverride IProblem.DisallowedTargetForAnnotation IProblem.DuplicateTargetInTargetAnnotation IProblem.AnnotationTypeDeclarationCannotHaveSuperclass IProblem.AnnotationTypeDeclarationCannotHaveSuperinterfaces IProblem.AnnotationMembersCannotHaveParameters IProblem.AnnotationMembersCannotHaveTypeParameters IProblem.AnnotationCannotOverrideMethod IProblem.IllegalModifierForAnnotationField IProblem.AnnotationValueMustBeClassLiteral IProblem.AnnotationValueMustBeConstant IProblem.DuplicateAnnotation IProblem.DuplicateAnnotationMember IProblem.MissingValueForAnnotationMember IProblem.UndefinedAnnotationMember IProblem.AnnotationCircularity IProblem.AnnotationCircularitySelfReference IProblem.InvalidAnnotationMemberType IProblem.IllegalModifierForAnnotationMemberType IProblem.IllegalModifierForAnnotationType IProblem.InvalidFileNameForPackageAnnotations IProblem.IllegalExtendedDimensions IProblem.IllegalModifierForAnnotationMethod IProblem.InvalidUsageOfAnnotationDeclarations IProblem.InvalidUsageOfAnnotations IProblem.InvalidUsageOfEnumDeclarations IProblem.InvalidUsageOfVarargs IProblem.InvalidUsageOfStaticImports IProblem.InvalidUsageOfTypeArguments IProblem.InvalidUsageOfWildcard IProblem.TypeHidingTypeParameterFromMethod IProblem.SuperTypeUsingWildcard IProblem.TypeArgumentsForRawGenericConstructor IProblem.TypeArgumentsForRawGenericMethod IProblem.IncorrectArityForParameterizedConstructor IProblem.ParameterizedConstructorArgumentTypeMismatch IProblem.NonGenericConstructor IProblem.ParameterizedMethodArgumentTypeMismatch IProblem.IncorrectArityForParameterizedMethod IProblem.NonGenericMethod IProblem.IllegalInstanceofParameterizedType IProblem.IllegalInstanceofTypeParameter IProblem.GenericConstructorTypeArgumentMismatch IProblem.GenericMethodTypeArgumentMismatch IProblem.TypeArgumentMismatch IProblem.ObjectCannotBeGeneric IProblem.NonConstantExpression
*** Bug 268051 has been marked as a duplicate of this bug. ***
Applied. Whew!