Bug 268002 - [ui] Alignment of buttons is really off
Summary: [ui] Alignment of buttons is really off
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-03-10 21:38 EDT by Pascal Rapicault CLA
Modified: 2009-04-16 17:13 EDT (History)
7 users (show)

See Also:

Attachments
Screenshot of the dialog (20.07 KB, image/png)
2009-03-10 21:38 EDT, Pascal Rapicault CLA 		no flags Details
windows (10.30 KB, image/png)
2009-04-09 11:03 EDT, Kevin Barnes CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2009-03-10 21:38:51 EDT 
Created attachment 128302 [details]
Screenshot of the dialog

The alignment of buttons in the p2 dialogs is particularly off on cocoa where they are fine on windows.
Comment 1 Kevin Barnes CLA 2009-04-09 11:03:38 EDT 
Created attachment 131402 [details]
windows

This is a layout problem. The buttons are in a composite (and separate GridLayout) from the text widgets. The alignment isn't quite right on windows either.
Comment 2 Curtis Windatt CLA 2009-04-09 11:17:11 EDT 
p2 provides this dialog.
Comment 3 Susan McCourt CLA 2009-04-16 17:13:09 EDT 
fixed in HEAD >20090416.

the widget tree in this dialog was wonky because we didn't use to have a name field.  Now we do, so it makes sense to line up the buttons with the fields, even though they don't really relate to each field.

note I kept the tab order to tab from name to location and then the buttons.