Bug 267961 - WPE drag and drop to source pane from palette doesn't work
Summary: WPE drag and drop to source pane from palette doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 3.0.5   Edit
Assignee: Cameron Bateman CLA
QA Contact:
URL: ORACLE_P1
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-10 15:50 EDT by Cameron Bateman CLA
Modified: 2009-05-06 12:53 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
deboer: pmc_approved+
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: review+

Attachments
Solves the basic problem but there is a weird highlighting problem in the SSE during drag (3.30 KB, patch)
2009-05-01 16:53 EDT, Cameron Bateman CLA 		no flags Details | Diff
includes previous patch and fix for odd drop target feedback (6.28 KB, patch)
2009-05-01 18:41 EDT, Gerry Kessler CLA 		no flags Details | Diff
Revert to earlier patch -- the second patch didn't work as intended. (3.30 KB, text/plain)
2009-05-04 18:35 EDT, Cameron Bateman CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Bateman CLA 2009-03-10 15:50:17 EDT 
Steps to reproduce:

1) Open the WPE on a JSP page.
2) Click on a tag (say JSF h:commandButton) in the palette.
3) Without releasing the mouse button (drag and drop) drag the tag over the SSE in the WPE.
4) The circle-with-slash icon will show, indicating that you cannot drop.  If you release the mouse, nothing will happen.

Note that click-drop (i.e. click on a palette entry, then click on the source pane) does work.
Comment 1 Raghunathan Srinivasan CLA 2009-03-13 18:43:15 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
This is a hot-bug requested by Oracle. The fix is required to enable Dnd from the Palette to the Source Page. This *may* need API changes.
    * Is there a work-around? If so, why do you believe the work-around is insufficient?
Clicking on the palette and dropping it on the Source Editor. However, this is not favored since it doesn't conform to UI standard of the adopter product.
Comment 2 Tim deBoer CLA 2009-04-07 11:10:42 EDT 
Agreed for late work, but if it does require API breakage (addition is ok) please revisit if this needs further approval or adopter notification.
Comment 3 Cameron Bateman CLA 2009-05-01 16:53:50 EDT 
Created attachment 134119 [details]
Solves the basic problem but there is a weird highlighting problem in the SSE during drag
Comment 4 Cameron Bateman CLA 2009-05-01 16:55:05 EDT 
Hey Gerry,

The attached patch seems to solve the basic drag/drop problem.  Can you take a look at the secondary issue with the weird highlighting problem on drag?
Comment 5 Gerry Kessler CLA 2009-05-01 18:41:34 EDT 
Created attachment 134128 [details]
includes previous patch and fix for odd drop target feedback

The strange drop feedback was due to the DesignerSourceDropTargetListener and the DesignerSourceMouseTrackAdapter fighting over who would set the caret location for the drop.   Commented out the code in the mouse tracker's mouse move, and all is now well.
Comment 6 Cameron Bateman CLA 2009-05-04 18:35:22 EDT 
Created attachment 134335 [details]
Revert to earlier patch -- the second patch didn't work as intended.
Comment 7 Cameron Bateman CLA 2009-05-04 18:36:45 EDT 
We will leave this fix with the weird SSE refresh bug for now.  Although annoying it doesn't not impair functionality or significantly impact usability.  Also, the highlight redraw can be manually cleared by the user by scrolling the window or select and unselecting the area of text.
Comment 8 Raghunathan Srinivasan CLA 2009-05-04 18:42:04 EDT 
PMC:
This patch is ready to be reviewed for RC1. This was one of the bug pre-approved for M7.
Comment 9 Raghunathan Srinivasan CLA 2009-05-04 18:43:15 EDT 
This patch has been reviewed by Gerry Kessler.
Comment 10 Cameron Bateman CLA 2009-05-05 19:38:04 EDT 
Taking this one back.
Comment 11 Cameron Bateman CLA 2009-05-05 19:39:50 EDT 
Patch checked in to HEAD (3.1).  Leaving open pending approval to backport to 3.0.5.  This fix is non-API affecting and fixes a serious defect in the Web Page Editor.
Comment 12 Cameron Bateman CLA 2009-05-06 12:53:28 EDT 
Committed to 3.0.5 stream.