Bug 267875 - changing API baseline name triggers re-build
Summary: changing API baseline name triggers re-build
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-03-10 11:07 EDT by Darin Wright CLA
Modified: 2009-08-03 09:13 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+


Attachments
fix (12.31 KB, patch)
2009-04-14 15:56 EDT, Michael Rennie CLA
no flags Details | Diff
updated patch (4.06 KB, patch)
2009-04-15 09:26 EDT, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2009-03-10 11:07:28 EDT
Using  I20090310-0100

* If I change the name of an API baseline, it triggers a full build. It should not be required, since the content of the baseline has not changed.
Comment 1 Michael Rennie CLA 2009-03-10 12:11:52 EDT
Good catch, as it is now we do not pear down what has changed when editing a baseline we consider any change as a reason to rebuild.
Comment 2 Michael Rennie CLA 2009-04-14 15:56:33 EDT
Created attachment 131839 [details]
fix

Add flag to the wizard that can tell us when a content change has taken place - which in turn is inspected on the pref page to know if the baselines' content has change to (to ask for a build or not). This patch also contains the the API tools portion of the fix for bug 272164
Comment 3 Michael Rennie CLA 2009-04-14 16:04:49 EDT
applied patch, please verify Darin W
Comment 4 Michael Rennie CLA 2009-04-14 17:03:56 EDT
reopening, playing with a bunch of changes at once and I managed to not get prompted for a build after un-setting the default baseline (when I should have)
Comment 5 Michael Rennie CLA 2009-04-15 09:26:31 EDT
Created attachment 131924 [details]
updated patch

This updated fix adds explicit flags for what has changed, instead of trying to figure out what happened when you press apply - to determine if a build should be proposed or not.
Comment 6 Michael Rennie CLA 2009-04-15 09:27:31 EDT
released updated patch, please verify Darin W
Comment 7 Darin Wright CLA 2009-08-03 09:12:55 EDT
Verified