Bug 267250 - [Legacy] PolylineConnectionEx should support #setLineDash(int[])
Summary: [Legacy] PolylineConnectionEx should support #setLineDash(int[])
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.2   Edit
Hardware: All All
: P3 normal
Target Milestone: 2.2   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 13:54 EST by Alex Boyko CLA
Modified: 2010-07-19 12:28 EDT (History)
2 users (show)

See Also:


Attachments
patch (1.80 KB, patch)
2009-03-05 13:54 EST, Alex Boyko CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2009-03-05 13:54:04 EST
Created attachment 127690 [details]
patch

LineAttributes have been adopted by Draw2D and GMF PolylineConnectionEx should adopt the new API and keep the old one working.
Currently, PolylineConnectionEx#setLineDash(int[]) is not working anymore.

Workarounds for bug 105358 need to be removed and new API adopted.

Marc, can you code review this fix please?
I'll commit the fix once a small fix to Draw2D Shape is delivered.
Comment 1 Marc Gobeil CLA 2009-03-05 14:43:13 EST
looks good to me!
Comment 2 Anthony Hunter CLA 2009-03-06 11:45:16 EST
(In reply to comment #0)
> I'll commit the fix once a small fix to Draw2D Shape is delivered.

Bug 267249 has been committed to GEF, so we can commit this fix to GMF. 

Comment 3 Anthony Hunter CLA 2009-03-17 17:38:19 EDT
Committed to HEAD since Alex is away this week.
Comment 4 Eclipse Webmaster CLA 2010-07-16 23:35:55 EDT
[target cleanup] 2.2 M6 was the original target milestone for this
bug
Comment 5 Eclipse Webmaster CLA 2010-07-19 12:28:33 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug