Bug 267169 - [compare] Java compare editor: NLS hover and hyperlink only work if another editor is open
Summary: [compare] Java compare editor: NLS hover and hyperlink only work if another e...
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 273454
Blocks:
  Show dependency tree
 
Reported: 2009-03-05 05:28 EST by Markus Keller CLA
Modified: 2020-05-14 16:16 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-03-05 05:28:25 EST 
I20090304-0834

Java compare editor: NLS hover and hyperlink only work if another Java editor on the same file is already open. That's rather unpredictable.

I was very confused when I was in a debug session, the default hover for an NLS field was the variable value hover, and when I pressed my 'Externalized String' hover modifier key, the NLS hover only appeared in some files.
Comment 1 Markus Keller CLA 2009-03-05 12:24:07 EST 
> hyperlink
Tomasz pointed out that Ctrl+click actually works. What doesn't work for links is the hyperlink target popup ("Open in 'XX.properties'" / "Open Declaration"): The popup doesn't appear unless another Java editor is open on the file.
Comment 2 Dani Megert CLA 2009-03-09 10:22:51 EDT 
Tomasz, do you have time to look into this?
Comment 3 Tomasz Zarna CLA 2009-03-09 10:55:18 EDT 
Sure, would 3.5 M7 be ok with you?
Comment 4 Dani Megert CLA 2009-03-09 11:01:03 EDT 
Sure.
Comment 5 Tomasz Zarna CLA 2009-03-19 06:56:45 EDT 
NLSKeyHyperlinkDetector.detectHyperlinks() returns null for an embedded text viewer from the Compare Editor. This is caused by the fact that  SharedASTProvider.getAST(...) call in line 64 returns non-null CompilationUnit only when another Java editor is open on the file.
Comment 6 Tomasz Zarna CLA 2009-03-26 09:10:36 EDT 
Passing WAIT_YES as wait flag to SharedASTProvider.getAST(...) the hyperlink target popup reappears with the missing "Open in '<bundle>.properties'". This is not a solution, it only proves that Java Compare does not provide AST on its own, it needs to have another CU editor open to work properly.
Comment 7 Dani Megert CLA 2009-04-24 09:43:39 EDT 
We should not start to mess with ASTs at this stage.
Please target early 3.6.
Comment 8 Tomasz Zarna CLA 2009-04-24 09:49:58 EDT 
Dani, isn't this one blocked by bug 273454 or bug 273455 you have filed recently?
Comment 9 Dani Megert CLA 2009-04-24 11:10:38 EDT 
>Dani, isn't this one blocked by bug 273454 or bug 273455 you have filed
>recently?
bug 273454 yes, bug 273455 no
Comment 10 Tomasz Zarna CLA 2010-03-12 07:20:32 EST 
Guys, given the fact that this bug is blocked by bug 273454 which has no Target Milestone set, do you think it would be OK to remove the target here? I don't want to sound like I'm pushing you into fixing it, the truth is that most probably I won't be able to fix this bug in 3.6.
Comment 11 Dani Megert CLA 2010-03-15 09:53:22 EDT 
>OK to remove the target here
Done.
Comment 12 Eclipse Genie CLA 2020-05-14 16:16:56 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.