Bug 267127 - Change export to use new p2 publishing for metadata
Summary: Change export to use new p2 publishing for metadata
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 272084 (view as bug list)
Depends on: 270882 270887
Blocks: 258822 268695
  Show dependency tree
 
Reported: 2009-03-04 18:07 EST by Andrew Niefer CLA
Modified: 2009-04-13 16:54 EDT (History)
6 users (show)

See Also:


Attachments
first patch (65.15 KB, patch)
2009-03-06 14:04 EST, Andrew Niefer CLA
no flags Details | Diff
building sites (17.56 KB, patch)
2009-04-01 18:22 EDT, Andrew Niefer CLA
no flags Details | Diff
Patch for products and multi-platform export (95.83 KB, patch)
2009-04-01 18:26 EDT, Andrew Niefer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2009-03-04 18:07:39 EST
We should try and switch export to use the new support for publishing metadata for M6.

Plugins/Features/Update Sites can go first.  I have this pretty much working, just need to fix a few details first.

Product export will be a bit more work and can go second.

I will attach patches
Comment 1 Andrew Niefer CLA 2009-03-06 14:04:20 EST
Created attachment 127849 [details]
first patch

Here is a patch that turns on publishing for features (and plugins) & update sites, if we aren't doing multi-platform export.

- There is no "Generate Metadata" option in the UI for exporting plugins/fragments.  I see no real reason why we couldn't turn it on.

- Products and multi-platform export will require larger changes because of the way UI runs each platform as a separate build.

- In the cases where we aren't using the new stuff, we do regular generation as before.
Comment 2 Curtis Windatt CLA 2009-03-10 12:10:48 EDT
We will do this early in M7.
Comment 3 Curtis Windatt CLA 2009-03-19 12:04:28 EDT
Applied the first patch to HEAD after reviewing/testing.
Comment 4 Chris Aniszczyk CLA 2009-03-19 13:09:06 EDT
cool, thanks Curtis. We need to make sure these changes go in early.
Comment 5 Chris Aniszczyk CLA 2009-03-28 16:13:52 EDT
Curtis/Andrew, I think this broke update site building.

I am unable to build an update site on the latest i-build.
Comment 6 Curtis Windatt CLA 2009-03-30 15:17:31 EDT
/home/cwindatt/Curtis/Workspace Target/.metadata/.plugins/org.eclipse.pde.core/temp/org.eclipse.pde.container.feature/compile.org.eclipse.pde.container.feature.xml:4: The following error occurred while executing this line:
/home/cwindatt/Curtis/Workspace Target/TestPlugin/build.xml:153: The following error occurred while executing this line:
java.lang.OutOfMemoryError: PermGen space
The following error occurred while executing this line:
/home/cwindatt/Curtis/Workspace Target/TestPlugin/build.xml:153: The following error occurred while executing this line:
java.lang.OutOfMemoryError: PermGen space

I do get these while building a test site, but I was able to build a site containing a feature from the my target successfully.
Comment 7 Ian Bull CLA 2009-04-01 17:26:02 EDT
I'm also unable to build an update site.

I created a feature (with not plugins) and created an update site project.  I added my feature to the update site, hit "build all" and got:

C:\workspace\p2\.metadata\.plugins\org.eclipse.pde.core\temp\org.eclipse.pde.container.feature\assemble.org.eclipse.pde.container.feature.win32.win32.x86.xml:87: The following error occurred while executing this line:
C:\workspace\p2\.metadata\.plugins\org.eclipse.pde.core\temp\org.eclipse.pde.container.feature\assemble.org.eclipse.pde.container.feature.win32.win32.x86.xml:152: Unable to find: sampleFeature.feature.group 1.0.0
The following error occurred while executing this line:
C:\workspace\p2\.metadata\.plugins\org.eclipse.pde.core\temp\org.eclipse.pde.container.feature\assemble.org.eclipse.pde.container.feature.win32.win32.x86.xml:152: Unable to find: sampleFeature.feature.group 1.0.0

My feature was called sampleFeature.



Comment 8 Andrew Niefer CLA 2009-04-01 18:22:36 EDT
Created attachment 130628 [details]
building sites

Patch to fix building sites.

We also are missing the generated categories from the resulting repository, see bug 270894
Comment 9 Andrew Niefer CLA 2009-04-01 18:26:59 EDT
Created attachment 130629 [details]
Patch for products and multi-platform export

This also includes the changes in the building sites patch.

This patch does the following:
1) for multi-platform export (features & products), run one invocation of pde/build for all the platforms at once (instead of multiple invocations, each of one platform)
2) Use new metadata publishing for product export
3) changes to the feature generation to put os/ws/arch filters on the plugin includes (necessary for multiple platforms in one pde/build invocation)


I believe these changes are complete, but this needs more testing.  Particularly product export both with and without the delta pack
Comment 10 Ian Bull CLA 2009-04-01 19:12:25 EDT
Is this bug related to (or a dup of) bug 241441?  
Comment 11 Curtis Windatt CLA 2009-04-03 11:20:54 EDT
Site building is working for me perfectly after the patch.

With a very simple product I get the following:
The following error occurred while executing this line:
/home/cwindatt/Curtis/Workspace Target/.metadata/.plugins/org.eclipse.pde.core/temp/org.eclipse.pde.container.feature/assemble.org.eclipse.pde.container.feature.p2.xml:41: The following error occurred while executing this line:
/home/cwindatt/Curtis/Workspace Target/.metadata/.plugins/org.eclipse.pde.core/temp/org.eclipse.pde.container.feature/assemble.org.eclipse.pde.container.feature.p2.xml:17: The following error occurred while executing this line:
/home/cwindatt/Curtis/Workspace Target/.metadata/.plugins/org.eclipse.pde.core/temp/org.eclipse.pde.container.feature/plugins/javax.servlet.source_2.5.0.v200806031605/build.xml:79: The following error occurred while executing this line:
java.io.FileNotFoundException: /home/cwindatt/Curtis/Workspace Target/javax.servlet/build.xml (No such file or directory)

I was roughly following the steps in the RCP cheatsheet, which uses the Hello World RCP Template.
Comment 12 Curtis Windatt CLA 2009-04-03 11:22:00 EDT
Moving out of my box since I would like as many people as possible to test this.  Chris has the most familiarity with product export.
Comment 13 Curtis Windatt CLA 2009-04-07 15:30:04 EDT
ping, Chris can you test this out as soon as possible.

The error I reported when exporting a product was due to a bad product definition, and has not effect on the metadata generation.

Andrew has done some additional testing as well.
Comment 14 Ian Bull CLA 2009-04-09 18:40:56 EDT
I have also tried the patch (to test bug 268695) and update sites seem to work for me now too.
Comment 15 Chris Aniszczyk CLA 2009-04-10 13:03:20 EDT
It looks like it's working for me now too.

However, I'm seeing issues on export with metadata creation. Let me grab a newer build to do more testing.
Comment 16 Chris Aniszczyk CLA 2009-04-13 12:42:51 EDT
Looks good for me now.
Comment 17 Andrew Niefer CLA 2009-04-13 13:25:45 EDT
Chris I don't see the changes in CVS, did you miss releasing this?
Comment 18 Chris Aniszczyk CLA 2009-04-13 13:34:28 EDT
Try again Andrew ;)

> 20090413

I really need to get git working in Eclipse... need git stash ;)

btw, I noticed export is slightly longer, not sure if people see the same.
Comment 19 James D. Miles CLA 2009-04-13 14:14:01 EDT
So do I need 20090413 or later to test this? Or is the 0407 I build complete?
Comment 20 Chris Aniszczyk CLA 2009-04-13 14:21:16 EDT
I would pick up the I20090414 build when it's published tomorrow.
Comment 21 Curtis Windatt CLA 2009-04-13 16:54:45 EDT
*** Bug 272084 has been marked as a duplicate of this bug. ***