Bug 267008 - No validation for opened external files in PDT
Summary: No validation for opened external files in PDT
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2009-03-04 07:27 EST by Vadim Punski CLA
Modified: 2012-01-04 12:20 EST (History)
3 users (show)

See Also:

Attachments
Fixing annotation behavior for external file (10.48 KB, patch)
2009-03-04 08:18 EST, Vadim Punski CLA 		alex.panchenko: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim Punski CLA 2009-03-04 07:27:12 EST 
Build ID: I20090202-1535

Steps To Reproduce:
1. Install pdt-all-in-one-win32-2.1.0M5
2. File->Open, existing php file

Actual:
No validation, error annotation, no squiggling, no outline updated.

Expected:
All the functionality should work as expected.


More information:
Comment 1 Alex Panchenko CLA 2009-03-04 07:36:37 EST 
Is there any difference compared to the previously filed bug 266668 ?
The problem is related to the current design of the external files support in editor.
Comment 2 Vadim Punski CLA 2009-03-04 07:57:20 EST 
Issue 266668 related to the problem that no model updated.
The current one is related to visual representation of all changes in the model.
Regarding the current implementation, you're right. 
Anyway, these fixes solve the current problem state and may be used in the future as a base.
Comment 3 Vadim Punski CLA 2009-03-04 08:18:58 EST 
Created attachment 127465 [details]
Fixing annotation behavior for external file

This fix is a continues the issue #266668 and fixes the no annotation problem for external files.
Comment 4 Roy Ganor CLA 2009-03-08 05:54:25 EDT 
reviewed the changes with Vadim,

committed to CVS head