Bug 266922 - [ds tooling] add a modified attribute to component
Summary: [ds tooling] add a modified attribute to component
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 272600 (view as bug list)
Depends on: 272599
Blocks:
  Show dependency tree
 
Reported: 2009-03-03 15:05 EST by Chris Aniszczyk CLA
Modified: 2009-04-20 06:18 EDT (History)
4 users (show)

See Also:


Attachments
org.eclipse.pde.ds.patch (12.07 KB, patch)
2009-04-20 06:17 EDT, Chris Aniszczyk CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2009-03-03 15:05:37 EST
[rfc 0134] DS - Better integration with ConfigAdmin/ManagedService

According the OSGi Service Platform Service Compendium R4, 4.1, the
Declarative Services will interact with the Configuration Admin
Service and, if there's an update of the configuration with the same
PID as the service id, the component will be deactivated and
reactivated with the new configuration properties.

Now, the Configuration Admin Service is able to push configuration changes
directly to the component using the Managed Service interface. This behavior,
however, cannot be combined with the Declarative Services, and on configuration
changes, the component will be de- and reactivated regardless.

I would need the SCR to detect the fact that a ManagedService interface is
provided for the PID corresponding to the service id (although that should
probably be implicit for the sake of simplicity, if it isn't defined), and NOT
deactivate the component in this case, but let it handle the update at
run-time.

It's not 100% clear to me if this requires changes to the configuration admin
service, but I suppose that the SCR could probably insert itself as a
middleware, not exposing the service from the component directly, and just
forwarding requests whenever the component is active.
------- Comment #1 From BJ Hargrave 2008-09-17 16:45:02 UTC [reply] ------- 
CPEG mtg: We add a modified attribute. If specified component will be called at
that method before the service properties are updated. modified method will
take same args as activate.
Comment 1 Chris Aniszczyk CLA 2009-03-03 15:23:47 EST
Stoyan, will Equinox DS support this new attribute?
Comment 2 Chris Aniszczyk CLA 2009-03-03 16:05:52 EST
Looks like this isn't necessary anymore.
Comment 3 Stoyan Boshev CLA 2009-03-04 02:52:32 EST
I have not implemented this feature yet. It is not added to the DS spec but I thought it would be added soon.
BJ, could you tell whether this feature will be included in DS spec for OSGi R4.2?

(In reply to comment #2)
> Looks like this isn't necessary anymore.
Why is it not necessary?
Comment 4 BJ Hargrave CLA 2009-04-16 20:27:56 EDT
The DS spec for 4.2 has been updated to include a modified attribute. See bug 272599 comment 0 for the specification details.
Comment 5 Chris Aniszczyk CLA 2009-04-16 20:29:09 EDT
*** Bug 272600 has been marked as a duplicate of this bug. ***
Comment 6 Chris Aniszczyk CLA 2009-04-20 06:17:55 EDT
Created attachment 132391 [details]
org.eclipse.pde.ds.patch

Adds a modified attribute on the component element.
Comment 7 Chris Aniszczyk CLA 2009-04-20 06:18:12 EDT
done.

> 20090420