Description Marc Gobeil 2009-02-27 13:26:30 EST

Created attachment 127029 [details]
patch fix for ColorsAndFontsPropertySection 

Build ID: I20081211-1908

Steps To Reproduce:
1. run profiler on diagram while creating and moving around objects

More information:
At the beginning of ColorsAndFontsPropertySection.refresh() it refreshes the image on its line and font color buttons.

It did so by calling ImageDescriptor.getImageData(), which creates a new image data structure every call, on a static final ImageDescriptor that never changes, then created a new image from it based on the font color, which probably hasn't change since the last refresh call, and did all this twice, once for the font color, then again for the line color.

I simply introduced a flag to track whether the respective colors have changed since the last refresh.  I didn't figure it was worth caching the ImageData for the few times the color has actually changed.

While I was in the area, I added generics to eliminate all but one of the warnings in this class.