Bug 266489 - [api tooling] No error for missing @since tag for overloaded methods with param using generic
Summary: [api tooling] No error for missing @since tag for overloaded methods with par...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-02-27 09:33 EST by Marc Khouzam CLA
Modified: 2009-05-05 09:33 EDT (History)
3 users (show)

See Also:
Michael_Rennie: review+

Attachments
Proposed fix + updated regression tests (6.73 KB, patch)
2009-04-27 15:56 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2009-02-27 09:33:29 EST 
The API Tooling does not report an error for a missing @since tag for overloaded methods that have a parameter that uses generics.

I saw this in 3.5M5.
To reproduce, choose any class that is being tracked by the API tooling.
Say the class has a method called foo()
Add the following

void foo(List<?> a);

there will not be an error for the missing @since tag.

Note the error is properly reported for:

void foo(List a);  // No generics used
void my_foo(List<?> a);  // Not overloaded method
Comment 1 Olivier Thomann CLA 2009-04-27 13:41:24 EDT 
It works fine using current 3.5M7 warmup build.
The only thing that could be improved is the usage of the generic signature in the missing @since tag marker.
Comment 2 Olivier Thomann CLA 2009-04-27 15:51:24 EDT 
Marker message arguments should use the generic signature.
Comment 3 Olivier Thomann CLA 2009-04-27 15:56:34 EDT 
Created attachment 133441 [details]
Proposed fix + updated regression tests
Comment 4 Olivier Thomann CLA 2009-04-27 15:57:42 EDT 
Released for 3.5M7.
Michael, please verify.
Comment 5 Marc Khouzam CLA 2009-04-28 09:16:35 EDT 
(In reply to comment #1)
> It works fine using current 3.5M7 warmup build.

I'll give it a try once I install M7.
Comment 6 Michael Rennie CLA 2009-04-30 14:11:05 EDT 
verified
Comment 7 Marc Khouzam CLA 2009-05-05 09:33:50 EDT 
(In reply to comment #1)
> It works fine using current 3.5M7 warmup build.

Confirmed that it works for me as well with M7

Thanks