Bug 266450 - [repo] Don't log OperationCanceledException
Summary: [repo] Don't log OperationCanceledException
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-02-27 04:54 EST by Markus Keller CLA
Modified: 2009-04-02 17:31 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-02-27 04:54:54 EST 
I20090224-0800

I clicked the Cancel button in a modal dialog that tried to access an update site.

!ENTRY org.eclipse.equinox.p2.artifact.repository 4 0 2009-02-27 10:49:14.203
!MESSAGE Unexpected error loading extension: org.eclipse.equinox.p2.updatesite.artifactRepository
!STACK 0
org.eclipse.core.runtime.OperationCanceledException
        at org.eclipse.equinox.internal.p2.updatesite.UpdateSite.loadSiteFile(UpdateSite.java:146)
        at org.eclipse.equinox.internal.p2.updatesite.UpdateSite.load(UpdateSite.java:92)
        at org.eclipse.equinox.internal.p2.updatesite.artifact.UpdateSiteArtifactRepositoryFactory.initializeRepository(UpdateSiteArtifactRepositoryFa
ctory.java:67)
        at org.eclipse.equinox.internal.p2.updatesite.artifact.UpdateSiteArtifactRepositoryFactory.load(UpdateSiteArtifactRepositoryFactory.java:50)
        at org.eclipse.equinox.internal.p2.artifact.repository.ArtifactRepositoryManager.factoryLoad(ArtifactRepositoryManager.java:59)
        at org.eclipse.equinox.internal.p2.core.helpers.AbstractRepositoryManager.loadRepository(AbstractRepositoryManager.java:651)
        at org.eclipse.equinox.internal.p2.core.helpers.AbstractRepositoryManager.loadRepository(AbstractRepositoryManager.java:610)
        at org.eclipse.equinox.internal.p2.core.helpers.AbstractRepositoryManager.basicRefreshRepository(AbstractRepositoryManager.java:202)
        at org.eclipse.equinox.internal.p2.artifact.repository.ArtifactRepositoryManager.refreshRepository(ArtifactRepositoryManager.java:97)
        at org.eclipse.equinox.internal.provisional.p2.ui.operations.ProvisioningUtil.refreshArtifactRepositories(ProvisioningUtil.java:232)
        at org.eclipse.equinox.internal.provisional.p2.ui.dialogs.RepositoryManipulationPage$18.run(RepositoryManipulationPage.java:492)
        at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Comment 1 Susan McCourt CLA 2009-03-09 13:10:25 EDT 
The UI looks for this exception but the problem is that the AbstractRepositoryManager is logging it.

See AbstractRepository line 637...

} catch (Exception e) {
//catch and log unexpected errors and move onto the next factory
log("Unexpected error loading extension: " + providers[i].getUniqueIdentifier(), e); //$NON-NLS-1$

I could fix this myself but I think we need a general sweep over the load code to find other places, so assigning to John for now.
Comment 2 John Arthorne CLA 2009-04-02 17:31:51 EDT 
Fixed in HEAD. I verified in the debugger that cancel during load was correctly propagated back up to the handler in the UI.