Bug 266045 - [NotationModel] BasicDecorationNodeImpl should return ELIsts implementing InternalEList
Summary: [NotationModel] BasicDecorationNodeImpl should return ELIsts implementing Int...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: Notation (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: ---   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-24 17:20 EST by Alex Boyko CLA
Modified: 2020-02-18 06:10 EST (History)
2 users (show)

See Also:

Attachments
proposed patch (2.70 KB, patch)
2009-02-24 17:20 EST, Alex Boyko CLA 		ahunter.eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2009-02-24 17:20:05 EST 
Created attachment 126631 [details]
proposed patch

Features that BasicDecorationNode doesn't support such as:
1) source/target edges
2) persisted/transient children
3) styles

Should return an EList that implements InternalEList.
Comment 1 Alex Boyko CLA 2009-02-24 17:20:41 EST 
Chris, could you review this patch please?
Comment 2 Alex Boyko CLA 2009-02-24 17:48:35 EST 
Ran various diagram JUnits - everything passed
Ran a memory consumption test on a large model. Didn't notice any regression in memory footprint.
Comment 3 Alex Boyko CLA 2009-02-25 11:55:34 EST 
Committed the fix for 2.2 (There is not much to review and Chris is aware of what's going in)
Comment 4 Eclipse Webmaster CLA 2010-07-16 23:36:10 EDT 
[target cleanup] 2.2 M6 was the original target milestone for this
bug
Comment 5 Eclipse Webmaster CLA 2010-07-19 12:26:19 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug