Bug 264877 - Parametrize LabelDirectEditPolicy to finally replace DescriptionDirectEditPolicy class
Summary: Parametrize LabelDirectEditPolicy to finally replace DescriptionDirectEditPol...
Status: NEW
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P2 normal
Target Milestone: ---   Edit
Assignee: Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 264882
  Show dependency tree
 
Reported: 2009-02-13 13:20 EST by Alex Shatalin CLA
Modified: 2010-07-19 21:59 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Shatalin CLA 2009-02-13 13:20:19 EST 
DescriptionDirectEditPolicy is a subclass of LabelDirectEditPolicy and it contains necessary functionality for editing pure-design diagram elements. In the same time:
1. This class is in internal package
2. Whole functionality of this class can be moved to it's superclass (LabelDirectEditPolicy) by adding appropriate parameter (like: "hasDomainElement"). 

The problem is: intention of DescriptionDirectEditPolicy AFAIKSee was just to replace EObjectAdapter creation logic from its parent. I think it does not make sense to create separate class for it (in addition just duplicating the logic from LabelDirectEditPolicy in this overriden method).

Currently generated code uses LabelDirectEditPolicy and does not work correctly for the pure-design diagram elements (diagram elements without undarlying domain model). The workaround for now is to switch off assertion, but i suppose this inconsistency in GMF runtime classes should be fixed in general.
Comment 1 Alex Shatalin CLA 2009-02-13 13:35:15 EST 
raising priority since generated code does not work in some with some particular settings nevertheless it requires rather simple runtim code corrections.
Comment 2 Eclipse Webmaster CLA 2010-07-19 21:59:01 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug