264739 – [publisher] move the root files under the feature group

Bug 264739 - [publisher] move the root files under the feature group

Summary: [publisher] move the root files under the feature group

Status:	RESOLVED FIXED

Alias:	None

Product:	Equinox
Classification:	Eclipse Project
Component:	p2 (show other bugs)
Version:	unspecified
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.5 M6
Assignee:	P2 Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	264746
	Show dependency tree

Reported:	2009-02-12 13:09 EST by Ian Bull
Modified:	2009-02-17 13:04 EST (History)
CC List:	1 user (show)

See Also:

Attachments
move root files under feature group (16.77 KB, patch) 2009-02-13 19:13 EST, Ian Bull	no flags	Details \| Diff
mylyn/context/zip (7.24 KB, application/octet-stream) 2009-02-13 19:13 EST, Ian Bull	no flags	Details
Updated Patch (17.51 KB, patch) 2009-02-13 20:31 EST, Ian Bull	aniefer: iplog+	Details \| Diff
mylyn/context/zip (9.41 KB, application/octet-stream) 2009-02-13 20:31 EST, Ian Bull	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ian Bull

2009-02-12 13:09:55 EST

The root files should be directly under the feature group.

Comment 1 Ian Bull

2009-02-13 19:13:29 EST

Created attachment 125704 [details]
move root files under feature group

This patch moves the root files IU under the feature group (not the feature jar)

Comment 2 Ian Bull

2009-02-13 19:13:38 EST

Created attachment 125705 [details]
mylyn/context/zip

Comment 3 Ian Bull

2009-02-13 20:31:41 EST

Created attachment 125708 [details]
Updated Patch

This updates the previous patch and it puts the feature.jar as a NON_ROOT.  The only root produced by the feature action is the feature group.

Comment 4 Ian Bull

2009-02-13 20:31:50 EST

Created attachment 125709 [details]
mylyn/context/zip

Comment 5 Ian Bull

2009-02-13 20:32:34 EST

Note.  There is a small change to PDE build with this patch.  CCing andrew.

Comment 6 Andrew Niefer

2009-02-17 13:04:25 EST

I released this with an additional change:
FeaturesAction#createGroupIU and FeaturesAction#createPatchIU
are changed to create the RequiredCapability using child.getFilter() instead of INSTALL_FEATURES_FILTER.  This is because root file IUs will generally have a platform specific filter, and we want them installed even if the feature jar is not.