Bug 264369 - Inconsistent result in incremental build for org.eclipse.pde.api.tools.builder.tests.usage.UnusedApiProblemFilterTests.testUnusedFilter2I()
Summary: Inconsistent result in incremental build for org.eclipse.pde.api.tools.builde...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-10 11:05 EST by Olivier Thomann CLA
Modified: 2009-04-28 14:53 EDT (History)
0 users

See Also:
Olivier_Thomann: review+


Attachments
patch (6.18 KB, patch)
2009-04-09 11:51 EDT, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2009-02-10 11:05:24 EST
Using HEAD, it seems that the unused filter detection doesn't work in incremental build when the corresponding type is removed.
This test only runs the usage check and that check gets an empty array of types to check in this case.
This requires investigation.
Comment 1 Olivier Thomann CLA 2009-02-18 11:36:35 EST
I'll release a fix for this one as part of the fix for bug 259997. I'll monitor the next N-builds to see if this is failing again.
Comment 2 Olivier Thomann CLA 2009-02-18 11:43:13 EST
Released a fix as part of the fix for bug 259997.
I'll monitor next N-builds.

Michael, please verify.
Comment 3 Olivier Thomann CLA 2009-02-20 14:26:22 EST
Still fail on Windows.
Comment 4 Olivier Thomann CLA 2009-02-20 14:27:02 EST
Disabled again.
Michael, please investigate.
Comment 5 Michael Rennie CLA 2009-03-11 10:42:51 EDT
with the fix in for bug 267998 I am no longer able to reproduce the test failure.

Olivier can you confirm this is the case?
Comment 6 Michael Rennie CLA 2009-03-16 10:22:49 EDT
re-enabled test, we shall see what happens in the next build before marking as fixed.
Comment 7 Michael Rennie CLA 2009-03-20 14:17:33 EDT
with the builder fixed the tests don't fail anymore.

closing as worksforme
Comment 8 Michael Rennie CLA 2009-03-24 17:12:43 EDT
reopening

working on tests for bug 233643 I had the full build version of the test fail seemingly randomly. Feels like a timing issue. 

I updated the filter tests to use the newer test framework for creating the test projects from a location and for creating / updating / deleting test files.
Comment 9 Olivier Thomann CLA 2009-03-27 09:00:51 EDT
Failed again in last N-build.
Comment 10 Olivier Thomann CLA 2009-03-30 08:49:16 EDT
I disabled the tests again last week-end.
Comment 11 Michael Rennie CLA 2009-04-03 13:21:15 EDT
the patch from bug 233643 comment # 38 seems to have addressed this, I have not been able to reproduce locally on Windows or Linux with that patch.
Comment 12 Michael Rennie CLA 2009-04-06 17:21:29 EDT
I was wrong, the tests failed again...disabling them again
Comment 13 Michael Rennie CLA 2009-04-09 11:49:33 EDT
applied patch, please verify Olivier
Comment 14 Michael Rennie CLA 2009-04-09 11:51:24 EDT
Created attachment 131408 [details]
patch

proposed fix

The problem was an ordering of events and I added in a resource event waiter to ensure the filter store has initialized before the test proceeeds
Comment 15 Olivier Thomann CLA 2009-04-28 14:53:33 EDT
Verified. Original problem is gone.