Bug 264356 - Remove copies of ListDialog and use API
Summary: Remove copies of ListDialog and use API
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2009-02-10 10:23 EST by Chris Aniszczyk CLA
Modified: 2009-03-18 10:15 EDT (History)
1 user (show)

See Also:

Attachments
org.eclipse.jdt.ui.patch (13.12 KB, patch)
2009-02-10 10:23 EST, Chris Aniszczyk CLA 		daniel_megert: review-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2009-02-10 10:23:09 EST 
ListDialog is API and for some reason JDT has two copies of the class for redundancy :)
Comment 1 Chris Aniszczyk CLA 2009-02-10 10:23:53 EST 
Created attachment 125252 [details]
org.eclipse.jdt.ui.patch

Here's a stab at it.
Comment 2 Chris Aniszczyk CLA 2009-02-10 10:24:05 EST 
How about M6 :D?
Comment 3 Dani Megert CLA 2009-02-10 10:46:33 EST 
The patch looks simple BUT: I did a quick comparison of the three ListDialog
classes and there are many diffs. In addition, one of the two in JDT dialogs has sets the WRAP style bit for its message.

Sorry, but most likely we will not have time to look into this as we have to review all the three classes and test that everything still works the same.
Comment 4 Dani Megert CLA 2009-02-10 10:47:10 EST 
Comment on attachment 125252 [details]
org.eclipse.jdt.ui.patch

Patch is not good as it alters the message area of one of the two dialogs.
Comment 5 Dani Megert CLA 2009-03-18 10:15:50 EDT 
Fixed in HEAD.
Available in builds > N20090317-1745.