Bug 264253 - PDE calculates wrong path when buildDirectory is a relative path and baseLocation depends on that
Summary: PDE calculates wrong path when buildDirectory is a relative path and baseLoca...
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-09 15:59 EST by martin CLA
Modified: 2022-11-15 12:31 EST (History)
2 users (show)

See Also:


Attachments
demo-application, which reproduces the bug (98.16 KB, application/zip)
2009-02-09 15:59 EST, martin CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description martin CLA 2009-02-09 15:59:04 EST
Created attachment 125169 [details]
demo-application, which reproduces the bug

Build ID: I20080617-2000

Steps To Reproduce:
1.adjust Properties in build.properties, such as baseLocation points to a valid Eclipse Installation in 3.4.0.
2. just run build.xml with target pde-build
3.produces
 java.io.FileNotFoundException: ...\base\eclipse\plugins\org.eclipse.pde.build_3.4.0.v20080604\scripts\productBuild\base\eclipse\plugins\org.eclipse.pde.build_3.4.0.v20080604\scripts\productBuild\productBuild.xml

baseLocation in somewhat doubled into the path right after the productBuild-Folder.


More information:
There is absolutely no problem with absolute paths.
Comment 1 Eric Jain CLA 2009-05-05 20:30:50 EDT
The buildDirectory property doesn't seem to support paths with spaces (not uncommon in Windows), either. These limitations can be worked around, but it does make the whole PDE build setup look a bit hackish...
Comment 2 Andrew Niefer CLA 2009-05-06 10:33:16 EDT
Eric, if your problem isn't specific to a relative buildDirectory,  can you please open a new bug with details and the error you see.  With the exception of bug 272769, the test suite passes when run in a directory with spaces (which implies a build directory with spaces).  Similarly, export from a workspace with spaces also implies a buildDirectory with spaces.
Comment 3 Eric Jain CLA 2009-05-06 13:58:16 EDT
You're right, paths with spaces work fine (the spaces-related problem was self-inflicted, while attempting to fix the build file to handle relative paths).

In any case, it appears that to make the build script handle a relative buildDirectory, only the following two additions are required:

  ...
  <property name="buildLocation" location="${buildDirectory}"/>
  ...

  <target name="build">
    <java classname="org.eclipse.equinox.launcher.Main" ...>
      ...
      <arg value="-DbuildDirectory=${buildLocation}"/>  
      ...
    </java>
  </target>
Comment 4 Lars Vogel CLA 2018-12-03 09:12:00 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 5 Lars Vogel CLA 2018-12-03 09:12:15 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 6 Eclipse Genie CLA 2020-11-24 08:47:16 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 7 Eclipse Genie CLA 2022-11-15 12:31:40 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.