Bug 263323 - NPE building/weaving broken code
Summary: NPE building/weaving broken code
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 1.6.4   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-02 19:38 EST by Andrew Clement CLA
Modified: 2009-02-03 12:35 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2009-02-02 19:38:05 EST 
Create a class, create an aspect affecting that class via around advice.  Build.
Break the aspect, incremental build and the error comes out.  Then whitespace change in the class and save - this incremental build will break with:

 java.lang.NullPointerException at
   org.aspectj.weaver.bcel.BcelAdvice.canInline(BcelAdvice.java:215) at
   org.aspectj.weaver.bcel.BcelAdvice.implementOn(BcelAdvice.java:304) at
   org.aspectj.weaver.Shadow.implementMungers(Shadow.java:613) at 
   org.aspectj.weaver.Shadow.implement(Shadow.java:527) at
   org.aspectj.weaver.bcel.BcelClassWeaver.implement(BcelClassWeaver.java:3051)

Because the aspect isn't in good enough shape to answer questions
Comment 1 Andrew Clement CLA 2009-02-03 12:35:05 EST 
fixed - guards in place to cope with this situation and weaving doesn't proceed for the broken advice.