Community
Participate
Working Groups
There are a few JDT UI test classes that were long ago copied and added to the CNF test quite. These have since (in M6) been moved into org.eclipse.ui.test.harness. The classes are: SWTEventHelper EditorTestHelper DisplayHelper DisplayWaiter They have started to diverge a little on both sides and it would be good if we had a single set of these that everyone could use and extend. I can align the ones in ui.test.harness to include any improvements that were done in the JDT UI versions, and so a patch to have the JDT UI tests use the ones in org.eclipse.ui.test.harness. And I would also be happy to take responsibility for maintaining them going forward if that would be helpful. Let me know if you want to go this direction and I will prepare a patch.
There are pros and cons. You listed the pros (to which I agree). The cons for us are: - we get stuff we don't want (e.g. extra plug-in started ==> perf impact) and extension contributions that can impact our tests. Currently there are just two perspectives but we don't even want/need them and someone might put other stuff in there. - we have to compare all the helpers one line by one because the slightest difference in the implementation can have performance impacts (of course on both sides of the scale) on our performance tests. I would accept your suggestions under the following conditions: - this is not done by us (as we don't have time for this) and the person who does the work has to ensure that there is 0 performance impact i.e. we want numbers for every single test before we go ahead. This should be in the form of perf results that we can compare. - plugin.xml gets removed from org.eclipse.ui.tests.harness and will never come back to prevent future side-effects - org.eclipse.ui.tests.harness.UITestHarnessPlugin. It is currently not used and basically dead useless code which in the future can cause side-effects if people start to use it (e.g. adding stuff to start(...) - the bundle is turned into a non-singleton bundle
