Description Johan Compagner 2009-02-02 05:18:58 EST

i have this class:

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

public class Test
{
	public static <T> T[] asArray(Iterator< ? extends T> it, Class<T> clazz)
	{
		List<T> lst = new ArrayList<T>();
		while (it.hasNext())
		{
			lst.add(it.next());
		}
		return lst.toArray((T[])java.lang.reflect.Array.newInstance(clazz, lst.size()));
	}

	public void test()
	{
		String[] asString = null;
		// eclipse 3.5M4 this worked in build  I20090129-1200 it doesnt anymore
		asString = Test.<String> asArray(getIterator(), String.class);

		// now i have to do this:
		Iterator<String> iterator = getIterator();
		asString = Test.<String> asArray(iterator, String.class);

		// this also works except if i have remove unnecessary cast enabled then the cast is removed and i get a compile error
		asString = Test.<String> asArray((Iterator<String>)getIterator(), String.class);
	}

	public Iterator getIterator()
	{
		return new Iterator()
		{
			public void remove(){}

			public Object next(){
				return null;
			}

			public boolean hasNext(){
				return false;
			}
		};
	}
}

the error is:
Type mismatch: cannot convert from Object[] to String[]	


I think the error now isnt right. It should see that it will return a string because it is type with Test.<String> it shouldnt look what goes into the method as arguments (that is just a warning that the iterator isnt generified)

also if this error was right. Then the cast shouldnt be removed by the unnecessary cast save action. Because it is needed.