Bug 262996 - [terminal][api] get rid of TerminalState.OPENED
Summary: [terminal][api] get rid of TerminalState.OPENED
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M5   Edit
Assignee: Michael Scharf CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2009-01-29 23:29 EST by Michael Scharf CLA
Modified: 2009-02-01 12:29 EST (History)
1 user (show)

See Also:


Attachments
Additional patch fixing ViewMessages (10.57 KB, patch)
2009-02-01 07:39 EST, Martin Oberhuber CLA
no flags Details | Diff
Additional Patch moving tm.terminal version to 3.0 (47.03 KB, patch)
2009-02-01 10:19 EST, Martin Oberhuber CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Scharf CLA 2009-01-29 23:29:19 EST
the State.OPEN seems obsolete -- therefore remove it
Comment 1 Michael Scharf CLA 2009-01-29 23:46:09 EST
fixed
Comment 2 Martin Oberhuber CLA 2009-02-01 07:39:45 EST
Created attachment 124373 [details]
Additional patch fixing ViewMessages

I also got rid of the NLS String ViewMessages.OPENED, fixed the Copyright dates and added a comment header for the change.
Comment 3 Martin Oberhuber CLA 2009-02-01 10:19:51 EST
Created attachment 124374 [details]
Additional Patch moving tm.terminal version to 3.0

I also had to rev up the tm.terminal plugin version to 3.0 because of the following:

- the OLD tm.terminal.serial had a reference to TerminalState.OPENED
- somebody could have RSE 3.0 and then use p2 to update only the terminal plugin
- result would be a non-working configuration

==> Because our own plugins have been consuming internal non-API, and their 
dependencies had been expressed as [2.0.0,3.0.0), I have to move up tm.terminal
version to 3.0.0 to ensure that the old plugins won't be compatible with the 
new tm.terminal (which doesn't have TerminalState.OPENED any more).

In retrospect, it was wrong to have a [2.0.0,3.0.0) dependency -- any bundle 
which consumes internal non-API should specify a [2.0.0,2.1.0) dependency. I 
have rectified this in the new bundles and features.

At the same time, I moved up the Copyright Year to 2009 in all the feature.properties and about.properties files. 

Having the tm.terminal bundle version at 3.0.0 for this release will also be beneficial for fixign bug 185348 -- when we eventually move all dependencies to
internal.provisional.api into REAL API, we can then change the bundel depdendency back to [3.0.0,4.0.0).