Community
Participate
Working Groups
Steps used to reproduce: 1) Open the PDE extension editor on a plugin.xml. 2) Find an extension that specifies a class 3) Enter an invalid class name into the text box such as foo,bar 4) Click the 'class' link. 5) New class wizard opens up with the name foo,bar. No errors, message says "Create a new Java class.", but the finish is disabled. If the user interacts with the dialog the error message shows up. I know the guidelines state that we are not supposed to have a wizard open with an error message, but in this case we are populating the dialog for the user. They don't expect to have to enter any information.
PDE must disable the 'class' link if the name is invalid and/or show that the name is invalid. It should also indicate whether the class exists or not because currently the behavior is not clear (open editor vs. new wizard).
*** Bug 271935 has been marked as a duplicate of this bug. ***
Now that bug 271935 is closed as a duplicate of this one, it should be noted that validity must be checked also for the package part of the class name (think of "org.something.package.MyClass" => "package" is not a valid identifier).
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This bug has been marked as stalebug a while ago without any further interaction. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.
Re-testing following the simple steps from comment 0 shows: the bug is still here in HEAD.
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/185903
(In reply to Stephan Herrmann from comment #7) > Re-testing following the simple steps from comment 0 shows: the bug is still > here in HEAD. It is between policy of not opening a wizard with error message ( instead opening with finish disabled and invalid name) and the usability issue. I think comment#9 improves a usability a lot and the change is all in PDE. @Stephan, What do you think?
(In reply to Eclipse Genie from comment #9) > New Gerrit change created: > https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/185903 If there are no objections to this, I will release this change next week.
Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/185903 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5040e738977c3740017c9e958dbc0001830ce83d
(In reply to Vikas Chandra from comment #10) > (In reply to Stephan Herrmann from comment #7) > > Re-testing following the simple steps from comment 0 shows: the bug is still > > here in HEAD. > > It is between policy of not opening a wizard with error message ( instead > opening with finish disabled and invalid name) and the usability issue. I > think comment#9 improves a usability a lot and the change is all in PDE. > > @Stephan, What do you think? Thanks, now it works as I had expected :) Thanks, Vikas
verified on Version: 2021-12 (4.22) Build id: I20211109-1800
