Community
Participate
Working Groups
I will provide a patch for these.
This only works if the fix to bug 215729 is also applied.
Created attachment 124896 [details] Suggested patch
back to you Dani, the patch is attached
Sorry Francis, that slipped through.
Hi Francis, the patch seems not to work i.e. Navigate > Go To > still does not show the actions in the menu. Besides the missing code that actually provides those menu items the other part of the patch looks good. It just needs some minor corrections: - changing the constructor's parameter type to IViewPart in the two actions is good but we also want to assert that it implements ISetSelectionTarget ==> add an assert to the constructors ==> add Javadoc that specifies this - added Javadoc in JavaNavigatorActionProvider has superfluous spaces - add your copyright notice to JavaNavigatorActionProvider - remove change to PackageExplorerActionGroup.java as it only added a copyright notice without providing any code.
(In reply to comment #5) >This only works if the fix to bug 215729 is also applied. Note that I did not check how we finally fixed bug 215729 and hence the missing piece might be in there.
(In reply to comment #6) > (In reply to comment #5) > >This only works if the fix to bug 215729 is also applied. > Note that I did not check how we finally fixed bug 215729 and hence the missing > piece might be in there. Thanks, according to the bug reports, it looks like it was fixed in the way I suggested, so something else is going on. I will have a look.
Frrancis, do you still plan to provide a fix for 3.6?