Bug 261973 - [assist] Constructor completion should be improved (bug 6930)
Summary: [assist] Constructor completion should be improved (bug 6930)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-22 04:00 EST by David Audel CLA
Modified: 2009-01-27 12:29 EST (History)
0 users

See Also:


Attachments
Proposed fix (27.15 KB, patch)
2009-01-22 04:06 EST, David Audel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2009-01-22 04:00:30 EST
build I20090120-1700

Some part of the fix added to fix bug 6930 could be improved:
1) A method BasicSearchEngine#match() has been added, the existing method should be used to avoid to duplicate code.
2) The threshold of opened binary types should based on the java model cache size instead of a constant
3) Parameter types in source files should correctly computed when simple type name is ambiguous
package p;
public class X {}
package q;
public class X {}
package r;
import q.X;
public class Y {
  public Y(X x){}
  public Y(p.X){}
}
4) Method ConstructorDeclarationPattern#queryIn() is a duplicate of ConstructorPattern#queryIn()
5) ConstructorDeclarationPattern#queryIn() add to much * in the key
Comment 1 David Audel CLA 2009-01-22 04:06:20 EST
Created attachment 123346 [details]
Proposed fix
Comment 2 David Audel CLA 2009-01-22 04:47:25 EST
released for 3.5M5.

All points are fixed.

Tests added
  CompletionTests2#testBug6930_34() -> testBug6930_35()

Test updated
  CompletionTests2#testBug6930_33()
Comment 3 Kent Johnson CLA 2009-01-27 12:29:03 EST
Verified for 3.5M5 using I20090126-1300