Bug 261594 - Adjust code to new PRE_REFRESH semantics
Summary: Adjust code to new PRE_REFRESH semantics
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Srikanth Sankaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 262363 263908 264095 265004 (view as bug list)
Depends on: 255325
Blocks:
  Show dependency tree
 
Reported: 2009-01-20 02:50 EST by Dani Megert CLA
Modified: 2009-03-20 08:20 EDT (History)
7 users (show)

See Also:

Attachments
proposed fix & test (3.23 KB, patch)
2009-02-10 03:37 EST, Srikanth Sankaran CLA 		jerome_lanneluc: iplog+
jerome_lanneluc: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-01-20 02:50:19 EST 
I20090120-0800.

As of yesterday, PRE_REFRESH is also sent if the workspace root is refreshed. So far no event was sent and the corresponding code in JDT Core (see references to
PRE_REFRESH in JDT Core) was not triggered. JDT Core needs to adjust its code to also handle the PRE_REFRESH on the workspace root.

See bug 255325 for details.
Comment 1 Jerome Lanneluc CLA 2009-01-28 10:25:17 EST 
*** Bug 262363 has been marked as a duplicate of this bug. ***
Comment 2 Jerome Lanneluc CLA 2009-02-06 09:17:16 EST 
*** Bug 263908 has been marked as a duplicate of this bug. ***
Comment 3 Francis Upton IV CLA 2009-02-08 15:01:42 EST 
*** Bug 264095 has been marked as a duplicate of this bug. ***
Comment 4 Srikanth Sankaran CLA 2009-02-10 03:37:19 EST 
Created attachment 125210 [details]
proposed fix & test


    Jerome  - Thanks for the regression test attached to duplicate bug#262363.
    Francis - Thanks for the patch attached to bug #263908, while that resolves the NPE, from the commentary in the related bug#255325 (as confirmed by discussion within team), it can be inferred that when a workspace pre-refresh is sent, the client has to arrange to treat that as a pre-refresh of all projects. The current proposed patch addresses that too.
Comment 5 Jerome Lanneluc CLA 2009-02-10 05:43:34 EST 
Comment on attachment 125210 [details]
proposed fix & test

Fix is good
Comment 6 Jerome Lanneluc CLA 2009-02-10 05:45:16 EST 
Fix and test released for 3.5M6
Comment 7 Frederic Fusier CLA 2009-03-10 07:52:23 EDT 
Verified for 3.5M6 using I20090310-0100.
Comment 8 Jerome Lanneluc CLA 2009-03-20 08:20:35 EDT 
*** Bug 265004 has been marked as a duplicate of this bug. ***