Bug 261554 - [jdt-weaving] Tweaking the weaving service
Summary: [jdt-weaving] Tweaking the weaving service
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 1.6.4   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 262229
Blocks:
  Show dependency tree
 
Reported: 2009-01-19 14:48 EST by Andrew Eisenberg CLA
Modified: 2009-03-13 12:55 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2009-01-19 14:48:45 EST
There are concerns that the weaving service can be intrusive and use resources even if no AspectJ projects are open or being used.

Here are the suggestions on what to do:
1. remove the caching service from the release
2. have weaving turned  off by default
3. when an aspectj project is opened or created, or if an existing project gets an AJ nature, prompt to see if weaving should be turned on
4. also include a way to stop showing these messages

Additionally, we want to do the following to gain more control over Equinox Aspects:
1. Fold the EA plugins and feature so that it is distributed in the same repository as AJDT
2. This will allow us to turn off associated sites
Comment 1 Andrew Eisenberg CLA 2009-01-19 14:49:49 EST
Once this is completed, we will do some profiling and find out exactly how much difference there is in resources.
Comment 2 Martin Lippert CLA 2009-01-24 09:48:05 EST
I would be very happy to see more analysis on the resource consumption of EA and potentially optimisations for it.

What we did in the past: if there is no aspect to be woven into a specific bundle, EA does not create a weaver for this bundle. We tweaked the implementation to avoid useless weaver creations. The same is true for the caching. If there are no aspects to be woven into a bundle, we create a dummy caching service for it that simply does nothing (to avoid useless writing to the cache dirs).
Comment 3 Andrew Eisenberg CLA 2009-03-13 12:55:52 EDT
This bug has been resolved.

(In reply to comment #0)
> 1. remove the caching service from the release
done.

> 2. have weaving turned  off by default
done.

> 3. when an aspectj project is opened or created, or if an existing project gets
> an AJ nature, prompt to see if weaving should be turned on
done.

> 4. also include a way to stop showing these messages
done.


> 1. Fold the EA plugins and feature so that it is distributed in the same
> repository as AJDT
> 2. This will allow us to turn off associated sites

Both of these have been done for AJDT 1.6.4.