Bug 260549 - Feature editor only shows warning on plug-ins tab when plug-in missing
Summary: Feature editor only shows warning on plug-ins tab when plug-in missing
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.1   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2009-01-09 09:59 EST by Wim Jongman CLA
Modified: 2009-09-16 15:53 EDT (History)
3 users (show)

See Also:

Attachments
Showing the problem (139.95 KB, image/png)
2009-01-09 10:05 EST, Wim Jongman CLA 		no flags Details
Patch for FeatureErrorReporter.java (5.46 KB, patch)
2009-08-06 13:58 EDT, Simon Muschel CLA 		curtis.windatt.public: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2009-01-09 09:59:47 EST 
This is a little problem with the feature editor. If a plugin in the list of plugins is no longer available due to version number changes then we see a little warning icon decorator in the plugin. This warning cannot be seen in the xml nor in the problems view.
Comment 1 Wim Jongman CLA 2009-01-09 10:05:49 EST 
Created attachment 122121 [details]
Showing the problem

Notice the little icon but no other indicators
Comment 2 Curtis Windatt CLA 2009-01-09 10:16:10 EST 
I tried this out and I got a warning on the plug-in tab, a warning in the feature.xml source tab, and a warning in the Problems View.

Can you please try to come up with a series of steps to reproduce?
Comment 3 Wim Jongman CLA 2009-01-09 10:45:35 EST 
Strange..

1. Create a plugin project test1
2. Create a feature project and add test1
3. Change the 0.0.0 version in the feature editors plugin tab for test1 to 1.0.0
4. Change the version number of test1 to 1.0.1

In my two eclipse versions:

Version: 3.4.0
Build id: I20080617-2000

and

Version: 3.4.1
Build id: M20080911-1700

Both with the same result/
Comment 4 Curtis Windatt CLA 2009-01-16 16:08:46 EST 
Following your exact steps I can reproduce now in both 3.5 and 3.4.x.

This would be a good polish fix during M6.
Comment 5 Simon Muschel CLA 2009-08-06 13:58:13 EDT 
Created attachment 143697 [details]
Patch for FeatureErrorReporter.java

I've added another validation step to FeatureErrorReporter. Now it checks, if a plugin with the given id and version is available in the PluginRegistry. If not a warning is shown in the problems view and the xml editor.
Comment 6 Curtis Windatt CLA 2009-08-06 14:03:11 EDT 
Thanks for the patch, should be able to review it for M2.
Comment 7 Curtis Windatt CLA 2009-08-10 16:40:17 EDT 
Applied the patch with trivial changes, the marker doesn't go away on a clean but that is a symptom of the feature error reporter.  Thanks for the patch Simon.
Comment 8 Curtis Windatt CLA 2009-09-16 15:53:59 EDT 
Verified in I20090915-0100