Community
Participate
Working Groups
Build ID: 3.5 I20081211-1908 Steps To Reproduce: See Bug 250554. More information: Looks the alreadyAddedElements fields keeps the status of retrieved children. But I can't see the reason for it. Because of this the addTypeChildren method will ignore the retrieved children, which caused the bug 250554. Since the getChildren() should return the real time children,I don't know why we need that alreadyAddedElements set. Patch applied
Created attachment 121772 [details] Patch to remove the set.
Applied patch into CVS.
Reopening. In Ruby class could be defined in multiple files. This check was needed to prevent multiple occurrences of the same class in the type hierarchy. So this check should not be simply removed, probably it should be moved to other place.
Thanks Alex for pointing out it. I guess we don't want to add duplicate Class in the List, but do we need a class field to keep this state? Can we just use a method level variable? Please review my new patch to see if it's all right, since I don't know how to setup the Ruby case.
Created attachment 121908 [details] Change the set to local variable.
1. adding back the alreadyAddedElements for Ruby implementation as Alex requested. 2. removing the redundant field alreadyAddedElements to a local variable Thanks,
Created attachment 132335 [details] Patch that fixes duplicate entries I suggest converting List to Set in order to eliminate duplicate file entries, like in AAA and BBB in following picture: Object file1.rb file2.rb | +--- AAA a.rb a.rb | +--- BBB b.rb b.rb
Reopening, since the behavior is still wrong (duplicate file entries)
Fixed in CVS.
