Bug 26011 - [boot/runtime] plugin.xml needs to change for classloader enhancements
Summary: [boot/runtime] plugin.xml needs to change for classloader enhancements
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Wassim Melhem CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-11-11 21:50 EST by DJ Houghton CLA
Modified: 2002-12-14 17:22 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2002-11-11 21:50:04 EST 
See bug 24667.

The classloader enhancements in the above mentioned bug report were implemented 
for 2.1 M3. We need to make these enhancements available to plug-in developers 
by letting them add mark-up to their plugin.xml files.

Note that PDE also needs to know about this DTD change.
Comment 1 DJ Houghton CLA 2002-11-13 21:16:20 EST 
Recommend that we use the following notation.
Multiple <package> entries may exist per <library> tag.
Comments?

  <runtime>
    <library name="runtime.jar">
      <export name="*"/>
      <package prefix="org.eclipse.core"/>
    </library>
  </runtime>
Comment 2 Jeff McAffer CLA 2002-11-18 22:34:16 EST 
Given the potential number of entries for the brute force listing of packages, 
this will result in many additional elements (one per package prefix).  I 
suggest the alternative structure shown below using comma-separated lists:

  <runtime>
    <library name="boot.jar">
      <export name="*"/>
      <package prefixes="org.eclipse.core,com.ibm.oti"/>
    </library>
  </runtime>

Note, I'm not sure if it is prefixes or prefixs?

This approach allows for the same style as originally proposed but also for the 
more compact multi-entry style shown here.

Also, it may be better for <package> to be <packages>.
Comment 3 Jeff McAffer CLA 2002-11-24 21:12:45 EST 
see also bug 24047
Comment 4 Jeff McAffer CLA 2002-11-24 21:13:39 EST 
see also bug 27048
Comment 5 DJ Houghton CLA 2002-11-25 11:38:12 EST 
see also bug 27047 (not bug 24047)
Comment 6 DJ Houghton CLA 2002-12-05 10:15:52 EST 
Adding Dejan to CC list.
The format will be as follows:

<runtime>
  <library name="boot.jar">
    <export name="*"/>
    <packages prefixes="org.eclipse.core,com.ibm.oti"/>
  </library>
</runtime>
Comment 7 Dejan Glozic CLA 2002-12-05 11:24:14 EST 
Just to clarify: is there a difference (apart from the syntax) in the following 
two examples:

<runtime>
  <library name="boot.jar">
    <export name="*"/>
    <packages prefixes="org.eclipse.core,com.ibm.oti"/>
  </library>
</runtime>

and

<runtime>
  <library name="boot.jar">
    <export name="*"/>
    <packages prefixes="org.eclipse.core"/>
    <packages prefixes="com.ibm.oti"/>
  </library>
</runtime>

If these two snippets are essentially equivalent, why providing two ways?
Comment 8 Dejan Glozic CLA 2002-12-05 11:27:39 EST 
Sorry, I just read the entire defect and saw Jeff's explanation :-).
Comment 9 Dejan Glozic CLA 2002-12-05 11:33:16 EST 
I've just noticed that LibraryModel does not support this yet. We depend on it 
in PDE Core because in several scenarios we load from a registry.
Comment 10 DJ Houghton CLA 2002-12-06 18:09:43 EST 
Released changes to ILibrary and LibraryModel in HEAD.

Will release rest of changes early next week. (including minor changes to the 
registry cache reader/writer...this is PDE's heads up :-)
Comment 11 Dejan Glozic CLA 2002-12-06 19:56:35 EST 
When you are done, please reassign the defect to us so that we can update our 
registry cache reader/writer.
Comment 12 DJ Houghton CLA 2002-12-09 23:05:32 EST 
Released to HEAD.
Re-assigning to PDE/UI for updating their copy of the Registry Cache 
Reader/Writer.
Comment 13 Dejan Glozic CLA 2002-12-10 09:30:48 EST 
Wassim, we need to pick up the changes in registry reader/writer.
Comment 14 Wassim Melhem CLA 2002-12-14 17:22:01 EST 
PDE's registry cache reader and writer have now been updated.