Community
Participate
Working Groups
Created attachment 121678 [details] DTP 1.6.2 Translation The attached zip file contains DTP 1.6.2 translated *.properties files for de_DE, es_ES, fr_FR, ja_JP, ko_KR, and zh_CN. Please integrete this into Babel Server. Thank you, Doshiro.
Can you please give the same information I asked you to give for 260013 ? Additionally, please state whether the translations were made by professionals and tested in context. Thanks!
Opened IPZilla CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2926
Hi, the review came back with those comments: Several plugin.properties files contained in the attachment contain the following header which cannot be used in Eclipse: # =================================================================== # Licensed Materials - Property of IBM # com.ibm.db.models.sql.query.edit # (C) Copyright IBM Corporation 2005. All Rights Reserved. # # Note to U.S. Government Users Restricted Rights: # Use, duplication or disclosure restricted # by GSA ADP Schedule Contract with IBM Corp. # =================================================================== The pertinent directories are: de_DE/eclipse/plugins/org.eclipse.datatools.modelbase.sql.query.edit es_ES/eclipse/plugins/org.eclipse.datatools.modelbase.sql.query.edit fr_FR/eclipse/plugins/org.eclipse.datatools.modelbase.sql.query.edit ko_KR/eclipse/plugins/org.eclipse.datatools.modelbase.sql.query.edit zh_CN/eclipse/plugins/org.eclipse.datatools.modelbase.sql.query.edit I've just checked the repo and the original file appears to have been corrected in June/08; therefore, these translations files must be re-addressed.
Doshiro-san, please take action regarding this contribution. Please remove the invalid headers identified in the previous comment, and submit your translations again, or it won't be possible to check those translations in.
Created attachment 128098 [details] Updated zip file. Fixed comments in org.eclipse.datatools.modelbase.sql.query.edit/plugin.properties files.
OK, sent the zip to the IPZilla for IP clearance. Thanks!
OK, this passed the IP review. Working on it.
Committed to staging. The symbols don't show ok on the recent translations page but they look ok in the translation UI: http://babel.eclipse.org/staging/translate.php?project=datatools&version=1.6&file=org.eclipse.datatools.connectivity/plugins/org.eclipse.datatools.connectivity.sqm.core/src/org/eclipse/datatools/connectivity/sqm/internal/core/rte/fe/GenericDdlGeneration.properties&string=GENERATE_PK_CONSTRAINTS_DES Please let me know if you think something is wrong with the translations provided. Doshiro-san, were those translations made by experts and tested in context ?
Those translations were contributed to the live server. You can see them through this URL: http://babel.eclipse.org/babel/recent.php?userid=18673 Thank you very much for this contribution!
Created attachment 129005 [details] Korean in S.Chinese Datatools files I just noticed a problem. I found some Korean characters in S.Chinese Datatools files. I spot checked a few files from Doshiro-san's contributions. It looks like they are in S.Chinese. Antoine, could you check the import script?
reopen bug
Check the import script .... ? The translations sat on the staging server for a week and everybody was happy with them. They have been contributed to the live server. You will need Denis to revert the translations intelligently, or I can delete all those contributed by Doshiro-san. What's the problem ? What should I do ?
Created attachment 129022 [details] DTP translation problem I think I found the problem. We expect all files under the root locale folder should contain translations for the same language. However, in each locale folder, for this particular plugin, there is a folder containing the translations in all 6 languages. See attached screen capture. Depending on the order we import the files, we may import a copy of the file in another language. I searched the translation zip. I only see one instance of such directory structure. We just missed this out of the ~1000 files in the zip. It's not easy to catch.
Created attachment 129023 [details] sqleditor-default-templates I've reorganized these sqleditor-default-templates files, removing all extra files in each locale folder, leaving only the German template in the German folder, the French template in the Fench folder, etc. Re-importing this attached zip and overwrite the current translations in the DB should fix the problem. Let's try that.
So the invalid translations are the Chinese ones only ? So I can remove the translations by Doshiro-san, on DTP, in Chinese, and redo the import. What do you think ? I'll paste the query here.
It's happening to all 6 languages because they all have the "nl" subdirectory in the contribution zip.
Aw, that's bad. I think I'd better go by using the key. I'll delete all the records with those keys translated by Doshiro-san.
OK so the query to get the invalid translations: select * from translations where string_id IN (SELECT string_id from strings where name="Templates.if" or name="Templates.ifelse" or name="Templates.elseif" or name="Templates.else" or name="Templates.author" or name="Templates.while_condition" or name="Templates.simple.select" or name="Templates.begin.end" or name="Templates.case.expr" or name="Templates.case.search" or name="Templates.event" or name="Templates.function" or name="Templates.sp" or name="Templates.trigger.asa" or name="Templates.trigger" or name="Templates.trigger.column" or name="Templates.cursor" or name="Templates.delete" or name="Templates.insert" or name="Templates.open.cursor" or name="Templates.update" or name="Templates." or name="Templates." or name="Templates." or name="Templates.create.table" or name="Templates.select.into") and userid = 18673 and is_active and language_id <> 9; Just have to replace select * by delete from.. let's do it.
(In reply to comment #18) > Just have to replace select * by delete from.. let's do it. Then we need to run the translations healer, because any previous translations will still be marked inactive. I believe the healer is in classes/export.
If we run the import script next, do we need to do that ? I deleted the strings just now on staging, I am about to import them. I will check how things go and will let you know if we need the healer script.
No, don't need to run that if you're reimporting. Thanks
I did all the cleanup on staging and live. Things went fine. Kit, can you please check everything went fine and the right values are present ?
I checked the translations of sqleditor default-templates in all 6 languages. The all look fine now. Thanks Antoine for fixing this! I'm saving the file link to Babel server for easier reference later: http://babel.eclipse.org/babel/translate.php?project=datatools&version=1.6&file=org.eclipse.datatools.sqltools/plugins/org.eclipse.datatools.sqltools.sqleditor/templates/default-templates.properties
Antoine, Kit, Thank you very much! Doshiro.
