Community
Participate
Working Groups
Currently, the o.e.equinox.launcher and the an associated platform-specific fragment is required to do a .product-based build. In some use cases (e.g. creating an servletbridge-based equinox server) the launcher bundles are not needed, and it would be very useful to be able to exclude the launcher bundles as part of .product-based PDE build.
This is possible now, exclude all launcher bits (exe, jar & fragment) by setting includeLaunchers=false. See also bug 255362, bug 255363
I'm reopening this, because the request was intended to include user interface in PDE build to allow this exclusion from PDE Product Export. I changed it to PDE UI component to reflect this...if this is a misclassification then feel free to change appropriately.
*** Bug 255362 has been marked as a duplicate of this bug. ***
reassigning to pde/ui inbox
Chris, what do you think about this? Shouldn't be hard to implement, though it is yet another option on the product export dialog.
(In reply to comment #5) > Chris, what do you think about this? Shouldn't be hard to implement, though it > is yet another option on the product export dialog. I'm thinking an option on the .product file is better. Somewhere on the launching page, you can specify via a checkbox that you want a launcher. This would than enable the launcher section for you to fill out. This would be enabled by default. Does this sound as an acceptable workflow for you Scott?
(In reply to comment #6) > (In reply to comment #5) > > Chris, what do you think about this? Shouldn't be hard to implement, though it > > is yet another option on the product export dialog. > > I'm thinking an option on the .product file is better. Somewhere on the > launching page, you can specify via a checkbox that you want a launcher. This > would than enable the launcher section for you to fill out. This would be > enabled by default. > > Does this sound as an acceptable workflow for you Scott? > I suppose, but it does seem to me more like an option for the export dialog. Maybe that's because I've been using the export dialog a lot, but it feels more like something done during a build/export rather than a launch within Eclipse (as it seems more about packaging...at least in the case of build of servers from product specs).
I think this is better done in the .product file as this file is becoming the focal point of a lot of p2 metadata generation. We are trying to separate the metadata generation to be more standalone and less reliant on pde.build, which means keeping eveything in the .product file as opposed to having product metadata depending on the build setup. (Though this means more work for me instead of just leaving it to UI to add an option in the export :) ) This will need to be sent back to build and to p2 once the option is in the .product file. Note that there were a couple of bugs here that said similar things, there are 3 cases: 1) include the exe and the launcher bundle and fragments 2) include the launcher bundle and fragments but not the exe 3) don't include any launcher pieces.
(In reply to comment #8) > I think this is better done in the .product file as this file is becoming the > focal point of a lot of p2 metadata generation. We are trying to separate the > metadata generation to be more standalone and less reliant on pde.build, which > means keeping eveything in the .product file as opposed to having product > metadata depending on the build setup. > > (Though this means more work for me instead of just leaving it to UI to add an > option in the export :) ) > > This will need to be sent back to build and to p2 once the option is in the > .product file. I completely understand the desire to put this option in the .product file (so that it's stored as metadata rather than in the build setup), but isn't this orthogonal to where/whether the UI allows the user to set the option? (i.e. couldn't it be in product export even if stored in .product file?
(In reply to comment #8) > Note that there were a couple of bugs here that said similar things, there are > 3 cases: > 1) include the exe and the launcher bundle and fragments > 2) include the launcher bundle and fragments but not the exe Who needs this case? And how would we instruct PDE Build to do this? > 3) don't include any launcher pieces.
Not sure about case #2. From a high level PDE user point of view there are three cases a) normal run a product/application use the exe and launcher stuff (standard RCP) b) use the exe and launcher stuff but not be doing a product/app (Equinox-based system) c) no exe/launcher and no product/app (WAR case) #2 is technically possible an some may want it. I'm not sure how popular it is.
Let's do this in M7 after the properties changes go in.
Created attachment 129015 [details] org.eclipse.pde.patch Adds a new button to say whether a product is launchable or not. The current checkbox wording is "The product is launchable" I'm not a big fan of this yet so I'm taking suggestions for better wording.
oh lovely, just realized it's "includeLaunchers" not excludeLaunchers... new patch coming.
(In reply to comment #13) > Created an attachment (id=129015) [details] > org.eclipse.pde.patch > > Adds a new button to say whether a product is launchable or not. > > The current checkbox wording is "The product is launchable" > > I'm not a big fan of this yet so I'm taking suggestions for better wording. > My $0.02: "The product will be launchable"...default true.
done. > 20090316 Thanks for the feedback.
(In reply to comment #13) > The current checkbox wording is "The product is launchable" > > I'm not a big fan of this yet so I'm taking suggestions for better wording. "Include native launcher with product"
*** Bug 255363 has been marked as a duplicate of this bug. ***
