Bug 259164 - [Extensions] Improve accessibility when browsing for extension schemas
Summary: [Extensions] Improve accessibility when browsing for extension schemas
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.1 M5   Edit
Assignee: Gabriel Indik CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: EaseOfUse
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2008-12-17 15:23 EST by Valentin Baciu CLA
Modified: 2009-05-04 16:15 EDT (History)
0 users

See Also:


Attachments
Screenshot (39.79 KB, image/x-png)
2008-12-17 15:23 EST, Valentin Baciu CLA
no flags Details
This patch replaces the non-standard toolbar used to select the schema source with the more common pair of buttons. (11.46 KB, patch)
2008-12-22 08:53 EST, Mike Oetlinger CLA
valentinbaciu: iplog+
Details | Diff
Screenshot of two buttons replacing the previously used menu. (227.61 KB, image/bmp)
2008-12-22 09:16 EST, Mike Oetlinger CLA
no flags Details
Replaces menu with right aligned buttons. (13.92 KB, patch)
2009-01-12 12:52 EST, Mike Oetlinger CLA
valentinbaciu: iplog+
Details | Diff
add accelerators to widgets on Add Category dialog (1.33 KB, patch)
2009-01-20 11:07 EST, Mike Oetlinger CLA
valentinbaciu: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Baciu CLA 2008-12-17 15:23:39 EST
Created attachment 120754 [details]
Screenshot

The extension category creation dialog uses a non-standard widget to allow the user to browse for the extension schema. This approach is also not very accessible. See the attached screenshot.

Perhaps we could use a solution similar to the one used for bug 111879.
Comment 1 Mike Oetlinger CLA 2008-12-22 08:53:06 EST
Created attachment 121063 [details]
This patch replaces the non-standard toolbar used to select the schema source with the more common pair of buttons.
Comment 2 Mike Oetlinger CLA 2008-12-22 09:16:33 EST
Created attachment 121068 [details]
Screenshot of two buttons replacing the previously used menu.
Comment 3 Mike Oetlinger CLA 2008-12-31 09:33:50 EST
Substituting buttons for the menubar makes the interface appear in a more standard fashion that is consistent with other dialogs in WTP.
Comment 4 Valentin Baciu CLA 2009-01-04 17:51:19 EST
Mike, we'll only mark the bug as fixed when the fix has been reviewed and committed.
Comment 5 Mike Oetlinger CLA 2009-01-12 12:52:02 EST
Created attachment 122301 [details]
Replaces menu with right aligned buttons.
Comment 6 Keith Chong CLA 2009-01-12 13:38:02 EST
Fix applied for 3.1M5.
Comment 7 Mike Oetlinger CLA 2009-01-12 14:02:19 EST
Bug resolved.
Comment 8 Valentin Baciu CLA 2009-01-19 14:12:14 EST
Keith, Mike, the two buttons appear to be missing shortcut keys (accelerators).
Comment 9 Mike Oetlinger CLA 2009-01-20 11:07:48 EST
Created attachment 123092 [details]
add accelerators to widgets on Add Category dialog

Allows for accessibility using just keyboard.
Comment 10 Valentin Baciu CLA 2009-02-03 14:46:18 EST
Too late for M5, moving to M6.
Comment 11 Valentin Baciu CLA 2009-02-25 17:10:42 EST
Gabriel, please review, commit and release.
Comment 12 Gabriel Indik CLA 2009-03-02 11:18:43 EST
The patch had already been committed by Keith on January 21. Note that in the specific case of the "name" label the accelerator key was removed given that it would have produced inconsistencies in other parts of the editor. A complete review of the tooling should eventually be conducted to evaluate all parts where accelerator keys need to be added.
Comment 13 Gabriel Indik CLA 2009-03-02 11:20:21 EST
Verified in WTP 3.1 M5 - 20090206233640
Comment 14 Valentin Baciu CLA 2009-05-04 16:15:56 EDT
Closing.