Bug 257407 - Usage of Platform non-API in org.eclipse.rse.ui
Summary: Usage of Platform non-API in org.eclipse.rse.ui
Status: ASSIGNED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 172649 253481
  Show dependency tree
 
Reported: 2008-12-03 13:23 EST by Martin Oberhuber CLA
Modified: 2011-05-31 17:38 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-12-03 13:23:09 EST 
In Problems View, configure filter to show 
   "Warning" of type "Java" with text filter "on required library"

Discouraged Access Warnings are shown on following classes:
  SystemShowPreferencesPageAction --> WorkbenchPreferenceDialog
  SystemView --> ProgressMessages

Also, RSE violates API contracts in following cases:
  SystemTableView illegally extends TableViewer
  ISystemAction illegally implements IAction
  SystemTeamView illegally extends TreeViewer
  SystemTableTreeView illegally extends TreeViewer
  SafeTreeViewer illegally extends TreeViewer
  SystemFilterWorkWithFilterPoolsTreeViewer illegally extends TreeViewer

We should get rid of these issues, or file bugs against Platform to open API that we need. This must be done until 3.1M6 latest to comply with Galileo requirement bug 253481. If Platform API changes are needed, these must be requested ASAP.

In some cases we may just be able to copy resources such as text Strings or images, in others we may need to creatively find proper ways of doing things.

Instead of extending TreeViewer, we should consider configuring it through the new API's it provides. Looking at the DebugView may help us here since it has requirements similar to ours.
Comment 1 Martin Oberhuber CLA 2010-05-27 08:26:01 EDT 
We need to get rid of non-API use soon in order to be ready for e4. Assigning 3.2.1 for now to make sure it gets looked at early enough.
Comment 2 David McKnight CLA 2010-08-20 09:36:30 EDT 
Moving some bug milestones from 3.2.1 to 3.2.2.
Comment 3 David McKnight CLA 2010-12-22 09:14:16 EST 
Bulk moving 3.2.x bugs to 3.3
Comment 4 Martin Oberhuber CLA 2011-05-31 17:38:45 EDT 
Moving 3.3 cleanup items to 3.3.1