Bug 257398 - Usage of Platform non-API in org.eclipse.rse.importexport
Summary: Usage of Platform non-API in org.eclipse.rse.importexport
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 4.5.100   Edit
Hardware: All All
: P1 blocker (vote)
Target Milestone: 4.5.200   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 172649 253481
  Show dependency tree
 
Reported: 2008-12-03 13:07 EST by Martin Oberhuber CLA
Modified: 2019-04-09 16:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-12-03 13:07:18 EST 
In Problems View, configure filter to show 
   "Warning" of type "Java" with text filter "on required library"

Discouraged Access Warnings are shown on following classes:
  RemoteImportWizardPage1 --> IElementFilter, ResourceTreeAndListGroup

We should get rid of these issues, or file bugs against Platform to open API that we need. This must be done until 3.1M6 latest to comply with Galileo requirement bug 253481. If Platform API changes are needed, these must be requested ASAP.

In some cases we may just be able to copy resources such as text Strings or images, in others we may need to creatively find proper ways of doing things.
Comment 1 Martin Oberhuber CLA 2010-05-27 08:26:01 EDT 
We need to get rid of non-API use soon in order to be ready for e4. Assigning 3.2.1 for now to make sure it gets looked at early enough.
Comment 2 David McKnight CLA 2010-08-20 09:36:28 EDT 
Moving some bug milestones from 3.2.1 to 3.2.2.
Comment 3 David McKnight CLA 2010-12-22 09:14:12 EST 
Bulk moving 3.2.x bugs to 3.3
Comment 4 Martin Oberhuber CLA 2011-05-31 17:38:45 EDT 
Moving 3.3 cleanup items to 3.3.1
Comment 5 Nick Boldt CLA 2019-04-01 23:36:32 EDT 
Building with:

mvn clean install -Dplatform-site=http://download.eclipse.org/eclipse/updates/4.12-I-builds/ -Dsdk-version=4.12-I-builds

I get this:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.3.0:compile (default-compile) on project org.eclipse.rse.importexport: Compilation failure: Compilation failure: 
[ERROR] /home/nboldt/4-eclipse.org/tm/org.eclipse.tm/rse/plugins/org.eclipse.rse.importexport/src/org/eclipse/rse/internal/synchronize/filesystem/FileSystemPlugin.java:[19] 
[ERROR] 	import org.eclipse.core.runtime.IPluginDescriptor;
[ERROR] 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The import org.eclipse.core.runtime.IPluginDescriptor cannot be resolved
[ERROR] /home/nboldt/4-eclipse.org/tm/org.eclipse.tm/rse/plugins/org.eclipse.rse.importexport/src/org/eclipse/rse/internal/synchronize/filesystem/FileSystemPlugin.java:[59] 
[ERROR] 	public FileSystemPlugin(IPluginDescriptor descriptor) {
[ERROR] 	                        ^^^^^^^^^^^^^^^^^
[ERROR] IPluginDescriptor cannot be resolved to a type

So we need to update RSE to work with Eclipse 4.12.

Upgrading to P1 blocker since we can't build anymore.
Comment 6 Nick Boldt CLA 2019-04-01 23:37:21 EDT 
If anyone on cc: wants to contribute a fix for this, I'll happily review and merge it.