Bug 257270 - [POLISH] Factor out various API settings to inner Options interfaces
Summary: [POLISH] Factor out various API settings to inner Options interfaces
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P1 enhancement (vote)
Target Milestone: M4   Edit
Assignee: Simon Mc Duff CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks: 250486
  Show dependency tree
 
Reported: 2008-12-02 16:27 EST by Eike Stepper CLA
Modified: 2010-06-29 09:21 EDT (History)
1 user (show)

See Also:
stepper: galileo+
stepper: review+

Attachments
Patch v1 (53.67 KB, patch)
2008-12-06 10:48 EST, Simon Mc Duff CLA 		no flags Details | Diff
Patch v2 - ready to be committed (108.05 KB, patch)
2008-12-06 14:11 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2008-12-02 16:27:25 EST 
CDOSession::Options
CDOView::Options
CDOTransaction::Options
Comment 1 Simon Mc Duff CLA 2008-12-06 10:48:56 EST 
Created attachment 119698 [details]
Patch v1

You can double check if I forgot some options ???
Comment 2 Eike Stepper CLA 2008-12-06 14:11:11 EST 
Created attachment 119702 [details]
Patch v2 - ready to be committed

Renamed getOptions() to options().
Added CDOView.Options.getCacheReferenceType().
Moved NO_REVISION_PREFETCHING to Options.
Removed commitTransactionTimeout because it's not used anymore.

I also renamed CDORevision::getData() to data() since it also just returns this.
Same for CDORevisionData.getRevision() --> revision().

I also moved various CDOSession methods to the new CDOSession.Repository
interface and added a repository() method.

Can you please add JavaDoc (from N&N?) for the remaining methods in:
- CDOSession.Options
- CDOView.Options
Comment 3 Simon Mc Duff CLA 2008-12-06 21:05:38 EST 
(In reply to comment #2)
> Created an attachment (id=119702)
> Patch v2 - ready to be committed
> 
> Renamed getOptions() to options().
> Added CDOView.Options.getCacheReferenceType().
> Moved NO_REVISION_PREFETCHING to Options.
> Removed commitTransactionTimeout because it's not used anymore.
> 
> I also renamed CDORevision::getData() to data() since it also just returns this.
> Same for CDORevisionData.getRevision() --> revision().
good idea
> 
> I also moved various CDOSession methods to the new CDOSession.Repository
> interface and added a repository() method.
> 
> Can you please add JavaDoc (from N&N?) for the remaining methods in:
> - CDOSession.Options
> - CDOView.Options
Wow you did more stuff that I did!!
Comment 4 Simon Mc Duff CLA 2008-12-06 21:15:53 EST 
Committed to HEAD Needs to update Javadoc (I updated N&N)
Eike, Should setStrongReferencePolicy should be CDOAdapterPolicy.ALL by default ?
Comment 5 Simon Mc Duff CLA 2008-12-06 21:32:49 EST 
Committed to HEAD (javadoc added)
Comment 6 Eike Stepper CLA 2008-12-19 12:36:31 EST 
Fix available in CDO 2.0.0M4
Comment 7 Eike Stepper CLA 2009-06-27 11:47:01 EDT 
Generally available.