Bug 257261 - [tcf] the daytime agent does not build on linux
Summary: [tcf] the daytime agent does not build on linux
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Michael Scharf CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 225082 255205
Blocks: 254917
  Show dependency tree
 
Reported: 2008-12-02 15:27 EST by Michael Scharf CLA
Modified: 2013-06-05 08:01 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Scharf CLA 2008-12-02 15:27:31 EST 
I just wasted a few hours to figure out why the daytime agent example does not build on ubuntu 8.10:  tcf has an include file named "elf.h" file and the system has an <elf.h> file and those get confused when building in the daytime.agent directroy!

The interestin code is in (tcf_)elf.h:

#if !defined(WIN32)
#  include <elf.h>
#endif

This works fine if the code is build in the same directory but it fails if the code is build using -I$(AGENT_DIR).

I locally renamed elf.h to tcf_elf.h and everything works fine.
Comment 1 Martin Oberhuber CLA 2008-12-12 06:53:36 EST 
Eugene, is it OK if Michael commits this fix (i.e. rename elf.h --> tcf_elf.h) ?

In the longer run, we should think about a more general solution to this. I could imagine putting all TCF headers into a "tcf" subdirectory and including them via

   #include "tcf/elf.h"

and the like. Thoughts?
Comment 2 Eugene Tarassov CLA 2009-02-09 16:24:27 EST 
Renamed: elf.h -> tcf_elf.h, elf.c -> tcf_elf.c
Comment 3 Martin Oberhuber CLA 2010-05-28 14:11:18 EDT 
Bulk update: Marking all TCF fixes from the Galileo period (Jun-2008 until Jun-2009) target 3.1 since they were done along with the TM 3.1 release.
Comment 4 Doug Schaefer CLA 2011-05-17 10:49:55 EDT 
Moving bugs to new home for IP log.
Comment 5 Martin Oberhuber CLA 2013-06-05 06:27:26 EDT 
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3