Bug 256966 - [l10n] Externalize Strings created Messages.java should set BUNDLE_NAME to Messages.class.getPackage().getName() + ".messages" to support renaming easier
Summary: [l10n] Externalize Strings created Messages.java should set BUNDLE_NAME to Me...
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-11-29 05:39 EST by Philipp Kursawe CLA
Modified: 2019-09-09 02:33 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Kursawe CLA 2008-11-29 05:39:38 EST 
The Messages.java class created by "Externalize Strings", when using the Eclipse way, sets the BUNDLE_NAME field to a string. During renaming of the package the string is easily missed to change too. Missing messages are the result.
I propose to create the Messsage.java and set BUNDLE_NAME like this:
private static final String BUNDLE_NAME = Messages.class.getPackage().getName() + ".messages"; //$NON-NLS-1$

Then when you rename the package the messages would still have the correct bundle name.
Comment 1 Eclipse Webmaster CLA 2019-09-06 15:31:21 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 2 Julian Honnen CLA 2019-09-09 02:33:41 EDT 
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.