Bug 255689 - [ui] Pressing update button in status bar may load repos (long wait)
Summary: [ui] Pressing update button in status bar may load repos (long wait)
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, usability
Depends on:
Blocks:
 
Reported: 2008-11-18 13:53 EST by Susan McCourt CLA
Modified: 2009-04-13 17:39 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2008-11-18 13:53:51 EST
When updates are available, an update button appears in the tool bar.  When the updates are first discovered, the repos are loaded and pushing this button is really fast.  But if you wait awhile before pushing this button, the repos are likely not loaded anymore, and pushing the button causes a long (hourglass) wait.  We need to load in the background in this case, or else have the update button hang onto the repo references in order to keep them alive.
Comment 1 John Arthorne CLA 2008-11-24 11:20:34 EST
Hanging onto the references sounds dangerous - the user may never click the button during that session.
Comment 2 Susan McCourt CLA 2008-12-15 11:31:03 EST
marking M6, as that is when I'll look at moving all actions into handlers (and the background loading code in the handlers can be used here).
Comment 3 Susan McCourt CLA 2009-04-13 17:39:39 EDT
This was fixed as part of the work for bug 268205 and some wizard reorg.
The update plan is computed in the background by the automatic updater, and any loading of repos that needs to happen then, happens.  On a profile change, we recompute the updates in the background, and if there are still updates, we compute a new plan in the background.  

When the popup or update button is pressed, the wizard immediately opens with the precomputed plan.  If the user changes the update selections, *then* it is possible that a new plan would need to be computed and repos would have to be reloaded, but this is true for all wizard workflows.