Bug 255292 - [UI] Add more information in the property panel for objects
Summary: [UI] Add more information in the property panel for objects
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.ui (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P1 enhancement (vote)
Target Milestone: M5   Edit
Assignee: Victor Roldan Betancort CLA
QA Contact:
URL:
Whiteboard: Power to the People
Keywords:
Depends on:
Blocks: 242224
  Show dependency tree
 
Reported: 2008-11-13 21:38 EST by Simon Mc Duff CLA
Modified: 2010-06-29 04:18 EDT (History)
2 users (show)

See Also:
stepper: galileo+
stepper: review+


Attachments
patch v1 - incomplete (10.79 KB, patch)
2009-01-02 11:32 EST, Victor Roldan Betancort CLA
no flags Details | Diff
patch v2 - incomplete (14.46 KB, patch)
2009-01-05 11:27 EST, Victor Roldan Betancort CLA
no flags Details | Diff
patch v3 (32.55 KB, patch)
2009-01-07 09:46 EST, Victor Roldan Betancort CLA
no flags Details | Diff
patch v4 (23.14 KB, patch)
2009-01-08 07:58 EST, Victor Roldan Betancort CLA
no flags Details | Diff
Patch v5 - ready to be committed (22.09 KB, patch)
2009-01-08 13:41 EST, Eike Stepper CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Mc Duff CLA 2008-11-13 21:38:22 EST
I would like to see (for advanced user)
- Container
- DirectResource
- STATE
- VIEW
- READLOCK WRITELOCK
- OID

Simon
Comment 1 Simon Mc Duff CLA 2008-11-13 21:39:55 EST
I added all I was described.. does someone has some needs ?

The problem is I'm not sure If I used components in the way they are supposed to be used!! :-(

I will provide a patch soon.

Simon
Comment 2 Eike Stepper CLA 2008-11-14 02:57:27 EST
That sounds good!

It's not necessary but maybe we want to show the adapters list and some change subscription info?
Comment 3 Simon Mc Duff CLA 2008-11-14 08:12:46 EST
(In reply to comment #2)
> That sounds good!
> 
> It's not necessary but maybe we want to show the adapters list and some change
> subscription info?
Good Idea!! I will also add the version of the revision, created, revised info if available (Proxy, TRANSIENT.. it is not available!)

Simon
Comment 4 Eike Stepper CLA 2008-11-14 09:24:38 EST
Oh yeah, that's interesting information, too!
I also thought about a change history per object, but that's maybe something for later ;-)
Comment 5 Victor Roldan Betancort CLA 2008-11-17 10:12:25 EST
Guys,

I'm not sure to have understood this properly: I assume you are trying to show up all that information in the "Properties View", right?

In that case, all that information would be nice from the development point of view, but I think some end-users might not be interested in seeing information in the property view when they are expecting values of a well-known package.

In that case (IMHO), this enhancement could be enabled from the preferences panel, and set off by default.

From the developer point of view, I think those are nice enhacements :)
Comment 6 Simon Mc Duff CLA 2008-11-17 10:14:04 EST
(In reply to comment #5)
> Guys,
> 
> I'm not sure to have understood this properly: I assume you are trying to show
> up all that information in the "Properties View", right?
> 
> In that case, all that information would be nice from the development point of
> view, but I think some end-users might not be interested in seeing information
> in the property view when they are expecting values of a well-known package.
> 
> In that case (IMHO), this enhancement could be enabled from the preferences
> panel, and set off by default.
> 
> From the developer point of view, I think those are nice enhacements :)
> 

Hi Vic,

Some of them no.. I agree. But it is why we put them into advanced users! :-)

Also some will be useful for the users
Session- Turn on/off passiveUpdate
etc..etc..

WHat do you think ?

Simon
Comment 7 Victor Roldan Betancort CLA 2008-11-17 10:21:26 EST
> Hi Vic,
> Some of them no.. I agree. But it is why we put them into advanced users! :-)

Great!

> Also some will be useful for the users
> Session- Turn on/off passiveUpdate
> etc..etc..
> WHat do you think ?

Yes, that would be lovely!
I've already seen some of your bugzillas and they look very interesting.
Specially the locking feature :)

The project I was working for just finished today (maintenance will start soon, though), so I think I could spend some time in UI enhancements :)
Comment 8 Simon Mc Duff CLA 2008-11-17 10:24:16 EST
(In reply to comment #7)
> > Hi Vic,
> > Some of them no.. I agree. But it is why we put them into advanced users! :-)
> 
> Great!
> 
> > Also some will be useful for the users
> > Session- Turn on/off passiveUpdate
> > etc..etc..
> > WHat do you think ?
> 
> Yes, that would be lovely!
> I've already seen some of your bugzillas and they look very interesting.
> Specially the locking feature :)
> 
Locking is already checked-in and available in M3 !! :-)

> The project I was working for just finished today (maintenance will start soon,
> though), so I think I could spend some time in UI enhancements :)
> 

Sounds good!! We should synchronized our effort to avoid duplicate work!

Comment 9 Eike Stepper CLA 2008-12-01 08:36:01 EST
Re-assigning to Vik in preparation of his new committer state...
Comment 10 Simon Mc Duff CLA 2008-12-02 13:24:13 EST
Already started...  I will ask you for a review!
Comment 11 Simon Mc Duff CLA 2008-12-03 10:37:45 EST
This bugzilla will only be for objects!
Comment 12 Simon Mc Duff CLA 2008-12-31 19:49:20 EST
I will not have time to do this one.
Vik, do you want to develop it.


Simon
Comment 13 Victor Roldan Betancort CLA 2009-01-01 11:09:37 EST
Sure! Have you already something done?

Comment 14 Simon Mc Duff CLA 2009-01-01 15:23:25 EST
Yes but I was not proud of it! I went to a bad direction...


Comment 15 Simon Mc Duff CLA 2009-01-01 15:23:46 EST
(In reply to comment #14)
> Yes but I was not proud of it! I went to a bad direction...
> 

So I deleted it long time ago...
Comment 16 Victor Roldan Betancort CLA 2009-01-01 15:55:37 EST
No prob :P
Comment 17 Victor Roldan Betancort CLA 2009-01-02 11:32:59 EST
Created attachment 121431 [details]
patch v1 - incomplete

- Added new option to UI Preferences Page, allows enabling/disabling debug property descriptors
- Already showing OID and Container. Container doesn't seem to show text correctly (using adapterFactory). Icon is properly shown.

Only remaning to add the missing IItemPropertyDescriptor. Pretty straightforward :)

Eike, A problem I experienced: I couldn't restore persisted status of the enablement, since Activator can't use/refer to a PREF attribute of OM during activation :( Any sugestion?
Comment 18 Victor Roldan Betancort CLA 2009-01-05 11:27:28 EST
Created attachment 121535 [details]
patch v2 - incomplete

- Fixed problems with IItemLabelProvider.
- Added cdoDirectResource
Comment 19 Simon Mc Duff CLA 2009-01-05 11:36:30 EST
Hi Vik,

I looked at the patch and wonder why you do not use the advanced properties to show the informations ?

Using 

private static boolean debugDescriptors = false;

isn't very flexible...

Do you expect to change that in the future ?
Comment 20 Victor Roldan Betancort CLA 2009-01-07 08:25:57 EST
Hi Simon,

I just didn't know of the existence of such filter! Is perfect for this feature :) This way I'm able to remove that boolean and the OMPreference (configurable through the preferences page). Much cleaner this way. Thanks!

(In reply to comment #19)
> Hi Vik,
> 
> I looked at the patch and wonder why you do not use the advanced properties to
> show the informations ?
> 
> Using 
> 
> private static boolean debugDescriptors = false;
> 
> isn't very flexible...
> 
> Do you expect to change that in the future ?
> 

Comment 21 Victor Roldan Betancort CLA 2009-01-07 09:46:19 EST
Created attachment 121813 [details]
patch v3

- Changed methodology: now using advanced properties filter. Removed from preferences page.
- All requested features to show are ready:
  * Container
  * DirectResource
  * CDOState
  * CDOView
  * ReadLock
  * WriteLock
  * OID
  * Adapters
  * Subscription types
  * Revision Version

- I overrode toString of the CDOAdapterPolicies instances, so it shows something meaningfull to the user instead of "CDOAdapterPolicies@f82ab12".

- I've realized that CDOObjects always show they have a ReadLock! Do I miss something??

Cheers,
ViK.
Comment 22 Victor Roldan Betancort CLA 2009-01-08 07:58:15 EST
Created attachment 121944 [details]
patch v4

- Added descriptor base class for CDO
- made descriptor classes public
- Added category
Comment 23 Eike Stepper CLA 2009-01-08 13:41:50 EST
Created attachment 121993 [details]
Patch v5 - ready to be committed

Very well done! It looks lovely ;-)

One note though: Certain state changes of an object are not reflected immediately (id, state, locks, etc). Can we become even better?
Comment 24 Victor Roldan Betancort CLA 2009-01-12 06:35:52 EST
Re-merged and committed to HEAD
Comment 25 Eike Stepper CLA 2009-02-13 01:22:23 EST
Fix available in CDO 2.0.0M5
Comment 26 Eike Stepper CLA 2009-06-27 11:46:58 EDT
Generally available.