Bug 255222 - Invalid tags leak into API descriptions
Summary: Invalid tags leak into API descriptions
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 231936
  Show dependency tree
 
Reported: 2008-11-13 11:41 EST by Michael Rennie CLA
Modified: 2009-03-10 17:20 EDT (History)
0 users

See Also:

Attachments
proposed fix (21.15 KB, patch)
2008-11-13 15:47 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2008-11-13 11:41:38 EST 
From testing the memory performance of our api descriptions I found that we leak restrictions for invalid tags into our api descriptions.

For example if you place a nooverride tag on a final method it will be set in the api description.
Comment 1 Michael Rennie CLA 2008-11-13 11:47:23 EST 
another example is adding a noreference tag to a class
Comment 2 Michael Rennie CLA 2008-11-13 15:47:32 EST 
Created attachment 117825 [details]
proposed fix

This patch closes all the leaks by doing some processing on the current tag context in the TagScanner. Tests have been added to ensure no more leaks appear in the api description, and delta tests have been updated
Comment 3 Michael Rennie CLA 2008-11-13 16:11:54 EST 
applied patch to HEAD
Comment 4 Michael Rennie CLA 2008-11-13 16:12:14 EST 
please verify Olivier
Comment 5 Olivier Thomann CLA 2009-03-10 17:20:55 EDT 
Verified.