Bug 255040 - JavaConventions.validatePackageName() method does not seem to work properly
Summary: JavaConventions.validatePackageName() method does not seem to work properly
Status: VERIFIED INVALID
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-12 09:12 EST by Georgi Dimitrov CLA
Modified: 2009-05-07 03:33 EDT (History)
2 users (show)

See Also:

Attachments
test (752 bytes, application/octet-stream)
2008-11-12 09:12 EST, Georgi Dimitrov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Georgi Dimitrov CLA 2008-11-12 09:12:44 EST 
Created attachment 117662 [details]
test

Build ID: M20080911-1700

Steps To Reproduce:
1.Call the JavaConventions.validatePackageName() method with (for example) this package -> "com. sap", (or "com  . sap   .   xxx")
2.The method indicates that the package name is valid.




More information:
I have attached a test.
Comment 1 Olivier Thomann CLA 2008-11-12 09:31:20 EST 
"com.  sap" is a valid package name and "co m.sap" is an invalid package name.
So I don't see what is wrong in this case.
Comment 2 Olivier Thomann CLA 2008-11-12 09:33:06 EST 
I updated org.eclipse.jdt.core.tests.model.JavaConventionTests#testValidPackageName with two new cases covering the cases you submitted.
Comment 3 Olivier Thomann CLA 2008-11-12 09:33:24 EST 
Closing as INVALID.
Comment 4 Frederic Fusier CLA 2008-12-09 06:24:56 EST 
Verified