Bug 254825 - [javadoc] compile error when referencing outer param from inner class javadoc
Summary: [javadoc] compile error when referencing outer param from inner class javadoc
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-10 23:11 EST by Hollis Waite CLA
Modified: 2008-12-09 13:50 EST (History)
1 user (show)

See Also:

Attachments
Proposed patch (3.05 KB, patch)
2008-11-17 05:38 EST, Frederic Fusier CLA 		no flags Details | Diff
New proposed patch (3.19 KB, patch)
2008-11-24 05:20 EST, Frederic Fusier CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hollis Waite CLA 2008-11-10 23:11:44 EST 
Build ID: M20080911-1700

Steps To Reproduce:
class Test {
  Object foo(Object o) {
    return new Object() {
      /** @see #o */
      void x() {}
    };
  }
}
Comment 1 Frederic Fusier CLA 2008-11-17 04:54:39 EST 
Problem was that, in this peculiar case, reference to #o is valid for the compiler but javadoc resolution try to report a problem. 

This case (fieldBinding.problemId()==0) was not expected in ProblemReporter.javadocInvalidField(...) method, hence got the missing compiler implementation error!
Comment 2 Philipe Mulet CLA 2008-11-17 05:15:24 EST 
Depending on the fix, we may want to backport it to 3.4.x. This kind of error is quite bad.

Is this a regression ?
Comment 3 Frederic Fusier CLA 2008-11-17 05:38:48 EST 
Created attachment 118039 [details]
Proposed patch

Patch is quite simple but this is not
Comment 4 Frederic Fusier CLA 2008-11-17 05:41:46 EST 
... this is not a regression. It was already there in 3.3.2 and I guess it should be the same for previous releases as there was no change in this area for a long time...
Comment 5 Frederic Fusier CLA 2008-11-24 05:20:04 EST 
Created attachment 118571 [details]
New proposed patch

Better patch which creates a problem field binding instead of tolerating NoError while reporting the problem...
Comment 6 Frederic Fusier CLA 2008-11-24 05:22:26 EST 
Released for 3.5M4 in HEAD stream.
Comment 7 Kent Johnson CLA 2008-12-09 13:50:07 EST 
Verified for 3.5M4 using I20081209-0100