Bug 254628 - [editor] [outline] Advice markers pointing in wrong direction in outline view
Summary: [editor] [outline] Advice markers pointing in wrong direction in outline view
Status: NEW
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-07 12:59 EST by Andrew Eisenberg CLA
Modified: 2008-11-11 12:09 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2008-11-07 12:59:00 EST
Just noticed that the advice markers in the editor and outline views are pointing in different directions.  I imagine that the editor is correct and the outline view is wrong.

Also, the advice markers in the outline view have decorators (showing that they have crosscutting relationships---duh!).  The decorators should be removed because they are just causing clutter.
Comment 1 Andrew Eisenberg CLA 2008-11-10 11:35:36 EST
OK.  I flipped the advice markers in the gutter, but I realize now that maybe those icons were correct, and it was the outline view that was the problem.  

The reason for this is that I would expect arrows to be flowing *out* of the advice and *into* advised methods.  Now it is the reverse.

I'll leave this bug open for now, so that in the future I may reverse all of them again.
Comment 2 Andrew Eisenberg CLA 2008-11-10 12:46:34 EST
Also, the decorators *should* appear on advice if advice affects it.  I have a small change that will address this.  Will go out in next dev build.
Comment 3 Andrew Clement CLA 2008-11-11 05:54:19 EST
yes, arrows flow out (pointing left) of advice and in (pointing right) to advised locations.  What could have triggered them to go wrong? something that has changed recently?
Comment 4 Andrew Eisenberg CLA 2008-11-11 11:32:23 EST
Well, since it's the outline view markers that are incorrect, and I haven't touched them since I started working on AJDT, my guess is that it's been like this for a while, but no one has noticed.
Comment 5 Andrew Clement CLA 2008-11-11 12:09:31 EST
Actually, they might be different in the *outline* view, not I spend a few minutes thinking about.  I bet the Eclipse AspectJ book would confirm it.

I wouldn't necessarily rush into changing the outline view ones until we've spent a bit more time thinking about it.