Bug 254431 - [plan] [jdt-weaving] [refactoring] Unable to rename a package whose aspects are used by another package
Summary: [plan] [jdt-weaving] [refactoring] Unable to rename a package whose aspects a...
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: 1.6.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.6.2   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 240021
Blocks:
  Show dependency tree
 
Reported: 2008-11-06 06:56 EST by Oren Mishali CLA
Modified: 2010-06-16 14:10 EDT (History)
1 user (show)

See Also:

Attachments
A simple project for reproducing the bug (3.14 KB, application/x-zip-compressed)
2008-11-06 06:56 EST, Oren Mishali CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oren Mishali CLA 2008-11-06 06:56:05 EST 
Created attachment 117180 [details]
A simple project for reproducing the bug

Build ID: M20080911-1700

Steps To Reproduce:
1. Import the attached project
2. Try to rename the package ajdt.renamepackagebug1

More information:
Aspect ajdt.renamepackagebug1.A is imported by ajdt.renamepackagebug2.B
Comment 1 Andrew Eisenberg CLA 2008-11-06 11:52:04 EST 
We have lots of problems with renaming/refactoring.  The root cause of this problem is that The refactoring agent wants to use a standard Java parser to perform the refactoring, but with AJ files, this will mean that the parsed files have syntax errors and the refactoring cannot proceed.

The proposed solution to this is to do JDT-weaving (bug 240021), where we weave into JDT and ensure that the parser always receives syntactically correct Java code.

In the meantime, a temporary solution is to rename packages in the Navigator view, not the Package explorer.
Comment 2 Andrew Eisenberg CLA 2008-12-11 13:16:12 EST 
Thanks for the failing project.  Now working with JDT Weaving enabled.  Going to translate this into a test case.
Comment 3 Andrew Eisenberg CLA 2008-12-11 14:51:22 EST 
Test case has been committed.