Comment 1 Vivian Kong 2009-03-11 13:06:21 EDT

We are using ICU4J.  Marking as fixed

Comment 2 Vivian Kong 2009-03-11 22:18:00 EDT

We actually haven't made the switch yet.  Reopening...

Comment 3 Vivian Kong 2009-03-11 22:21:01 EDT

Created attachment 128493 [details]
proposed patch

Changes proposed in this patch:

- update import statements in plug-ins
- add com.ibm.icu.text as an import package in all of the affected plug-ins

Comment 4 Pawel Piech 2009-03-12 00:09:44 EDT

(In reply to comment #3)
I did a quick test of the patch and it seems to work fine in the debugger views.
+1

Comment 5 Anton Leherbauer 2009-03-12 07:39:01 EDT

+1 Thanks Vivian, looks good.

Comment 6 Markus Schorn 2009-03-12 10:32:03 EDT

looks good to me.

Comment 7 Marc Khouzam 2009-03-12 14:00:38 EDT

Looks good.
I noticed in DSF-GDB that because of a slight change in the signature of MessageFormat.format(...), we now have warnings of unnecessary cast to (Object[]).

Once you apply your patch, I'll clean up the four of five instances of that warning.

The only other plugins that I had time to check was the DSF ones, where there is no such warnings.

Comment 8 Pawel Piech 2009-03-13 00:51:20 EDT

I committed changes in debug-dsf and debug-dsf-gdb components to avoid needless merging.

Comment 9 Vivian Kong 2009-03-13 09:48:25 EDT

(In reply to comment #8)
> I committed changes in debug-dsf and debug-dsf-gdb components to avoid needless
> merging.

Thanks Pawel.

Thanks to everyone for reviewing.  Fixed in HEAD.

Comment 10 Marc Khouzam 2009-03-13 09:52:28 EDT

Created attachment 128706 [details]
Fix warnings in DSF-GDB

As mentioned, the new MessageFormat no longer needed a cast.  This patch removes the unnecessary cast in DSF-GDB to avoid warnings.

Committed.