Bug 254127 - Capabilities
Summary: Capabilities
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: releng (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 1.7M4   Edit
Assignee: Brian Fitzpatrick CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 252807
  Show dependency tree
 
Reported: 2008-11-05 18:23 EST by Anne Jacko CLA
Modified: 2009-03-09 13:51 EDT (History)
1 user (show)

See Also:
bfitzpat: iplog+


Attachments
Possible changes (5.12 KB, patch)
2009-01-08 12:58 EST, Brian Fitzpatrick CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne Jacko CLA 2008-11-05 18:23:39 EST
+++ This bug was initially created as a clone of Bug #252807 +++

Each project will provide basic capability/activity definitions to allow for their UI contributions to be hidden. These must be provided in a separate plugin/feature to facilitate inclusion/exclusion by consumers in product development.
Comment 1 Brian Fitzpatrick CLA 2008-11-06 14:11:08 EST
I've already started working on this functionality in a separate plug-in. Some additional work will need to occur so this is handled correctly in the Data Source Explorer, but we'll get it done.
Comment 2 Brian Fitzpatrick CLA 2008-12-03 18:31:57 EST
Added a new org.eclipse.datatools.capabilities plug-in today that acts as a very high-level way to turn all DTP functionality off. Defaults to on. Currently investigating a weird behavior with the Common Navigator Framework with the Platform team, but am working on getting this into the Galileo build so it's at least represented. 

More work remains to be done if we choose to make the capability more fine-grained. 
Comment 3 Brian Fitzpatrick CLA 2008-12-04 14:04:12 EST
Setting the IPlog flag
Comment 4 Brian Fitzpatrick CLA 2009-01-08 12:58:08 EST
Created attachment 121991 [details]
Possible changes

This patch contains some possible changes required to react to Capabilities/Activities support in the workspace. More work needs to be done in various places I suspect (such as in the DSE), but this is a start.
Comment 5 Brian Fitzpatrick CLA 2009-03-02 11:45:08 EST
Closing as fixed. Have done all I can for this release. If more needs to be done, we can address it when the need is more clearly documented.
Comment 6 Brian Fitzpatrick CLA 2009-03-04 16:18:28 EST
Reopening now that I have additional information as indicated by http://wiki.eclipse.org/Galileo_Capabilities
Comment 7 Brian Fitzpatrick CLA 2009-03-04 16:31:46 EST
Xiaoying, I'm guessing you have access to the /cvsroot/callisto CVS directory for your build work with Galileo, so can I get you to take care of this for me? 

We need to follow the steps as noted here: http://wiki.eclipse.org/Galileo_Capabilities

I've taken care of step 1, but the other steps require changes to map files and such in the Galileo build area. In /cvsroot/datatools/org.eclipse.datatools.build/org.eclipse.datatools.capabilities exists. I fixed it based on the info in step 1 of the wiki page and delivered those changes as tag v200903050520.

Steps 2 and 3 seem pretty self explanatory.

For step 4, we need to add something along these lines:

    <!-- Data Tools in Development category -->
    <categoryActivityBinding
          activityId="org.eclipse.datatools.capabilities.activity"
          categoryId="org.eclipse.categories.developmentCategory">
    </categoryActivityBinding>

This should satisfy the requirement for capabilities. 

Thanks a ton for your help with this. Really appreciate it!
--Fitz    
Comment 8 Xiaoying Gu CLA 2009-03-05 04:16:48 EST
(In reply to comment #7)
> Xiaoying, I'm guessing you have access to the /cvsroot/callisto CVS directory
> for your build work with Galileo, so can I get you to take care of this for me? 
> We need to follow the steps as noted here:
> http://wiki.eclipse.org/Galileo_Capabilities
> I've taken care of step 1, but the other steps require changes to map files and
> such in the Galileo build area. In
> /cvsroot/datatools/org.eclipse.datatools.build/org.eclipse.datatools.capabilities
> exists. I fixed it based on the info in step 1 of the wiki page and delivered
> those changes as tag v200903050520.
> Steps 2 and 3 seem pretty self explanatory.
> For step 4, we need to add something along these lines:
>     <!-- Data Tools in Development category -->
>     <categoryActivityBinding
>           activityId="org.eclipse.datatools.capabilities.activity"
>           categoryId="org.eclipse.categories.developmentCategory">
>     </categoryActivityBinding>
> This should satisfy the requirement for capabilities. 
> Thanks a ton for your help with this. Really appreciate it!
> --Fitz    

I have updated the corresponding files mentioned in the wiki. 
   /cvsroot/callisto/org.eclipse.galileo/plugin.xml,v  <--  plugin.xml
     /cvsroot/callisto/org.eclipse.galileo-feature/feature.xml,v  <--  feature.xml
   /cvsroot/callisto/org.eclipse.galileo.build/maps/galileo.map,v  <--  maps/galileo.map
 
Please have a double check. I assume that we have to wait for the next galileo build for check.

And I found that this plugin was never added into current dtp build. Which feature should add it into?
Comment 9 Brian Fitzpatrick CLA 2009-03-05 09:23:10 EST
Thanks for doing that Xiaoying... Honestly, since we have the option of NOT including this in our download zips and just have it in the Galileo main build, I'd rather not include it in any of our features. 

I'll be happy to check it out the next time we see a Galileo build however...
Comment 10 Brian Fitzpatrick CLA 2009-03-05 16:47:19 EST
Hey Xiaoying... Can I have you make one more tweak? In my local testing it appears that without this:

    <!-- Data Tooling enabled by default -->
    <defaultEnablement
          id="org.eclipse.datatools.capabilities.activity">
    </defaultEnablement>

None of the DTP functionality is available by default. Can you add it where it suggests in step 4 on the Wiki? 
Comment 11 Xiaoying Gu CLA 2009-03-06 10:10:33 EST
(In reply to comment #10)
> Hey Xiaoying... Can I have you make one more tweak? In my local testing it
> appears that without this:
>     <!-- Data Tooling enabled by default -->
>     <defaultEnablement
>           id="org.eclipse.datatools.capabilities.activity">
>     </defaultEnablement>
> None of the DTP functionality is available by default. Can you add it where it
> suggests in step 4 on the Wiki? 

I have updated with that.

Comment 12 Brian Fitzpatrick CLA 2009-03-06 10:12:39 EST
Thanks for the help Xiaoying! I'll try and give this a test next week with an updated build for Galileo.
Comment 13 Brian Fitzpatrick CLA 2009-03-09 13:51:58 EDT
Considering this done.