Bug 253483 - APIs
Summary: APIs
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Releng (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: M6   Edit
Assignee: Nick Boldt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 271854 271857 272227
Blocks: 252794
  Show dependency tree
 
Reported: 2008-11-03 18:53 EST by Anne Jacko CLA
Modified: 2018-01-22 11:36 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne Jacko CLA 2008-11-03 18:53:34 EST 
+++ This bug was initially created as a clone of Bug #252794 +++

Projects should leverage only published APIs of dependencies. As a Release Review requirement, deviations should be listed as part of a migration plan, with bugs listed where APIs need to be provided by dependent projects.
Comment 1 Eike Stepper CLA 2008-12-11 15:26:29 EST 
Recognized for CDO/Net4j.
Comment 2 Martin Taal CLA 2008-12-11 15:43:26 EST 
Recognized by Teneo
Comment 3 Christian Damus CLA 2009-03-18 19:48:04 EDT 
The following components use only public API of dependencies:

Query
Transaction
Validation
Comment 4 Dave Steinberg CLA 2009-04-16 15:17:48 EDT 
We have fixed/will fix the following API deviation bugs in EMF Core: 271854, 271857, 272227.

This leaves the following seven deviations unresolved:

ExtendedComboBoxCellEditor illegally extends ComboBoxCellEditor
org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/celleditor/ExtendedComboBoxCellEditor.java:42

ExtendedTableTreeViewer illegally extends TableTreeViewer
org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/viewer/ExtendedTableTreeViewer.java:45

EDataTypeCellEditor illegally extends TextCellEditor
org.eclipse.emf.edit.ui/src/org/eclipse/emf/edit/ui/provider/PropertyDescriptor.java:205

IntegerCellEditor illegally extends TextCellEditor
org.eclipse.emf.edit.ui/src/org/eclipse/emf/edit/ui/provider/PropertyDescriptor.java:307

FloatCellEditor illegally extends TextCellEditor
org.eclipse.emf.edit.ui/src/org/eclipse/emf/edit/ui/provider/PropertyDescriptor.java:356

ExtendedPropertySheetPage illegally extends PropertySheetPage
org.eclipse.emf.edit.ui/src/org/eclipse/emf/edit/ui/view/ExtendedPropertySheetPage.java:42

SimpleMappedObjectViewer illegally extends TreeViewer
org.eclipse.emf.mapping.ui/src/org/eclipse/emf/mapping/presentation/SimpleMappedObjectViewer.java:50

They're not fixable, since they all constitute API, themselves.  There's nothing we can do but document them.
Comment 5 Dave Steinberg CLA 2009-05-06 09:36:21 EDT 
According to bug 252794, we minimally need a list of API deviations to meet this requirement.

Could each component supply their list of deviations, a link to it (if it is elsewhere), or an all clear (if there are none)?
Comment 6 Martin Taal CLA 2009-05-06 09:48:33 EDT 
Teneo: all clear from an api perspective
Comment 7 Eike Stepper CLA 2009-05-06 11:20:07 EDT 
CDO/Net4j uses no internal code of dependencies.
Comment 8 Dave Steinberg CLA 2009-05-10 21:51:54 EDT 
This one's done, too.  Only EMF Core has API deviations, as listed in comment 4.
Comment 9 Ed Merks CLA 2018-01-22 11:36:52 EST 
Closing all fixed releng bugs.