Bug 252863 - clean up UI for Queries and generators for consistency
Summary: clean up UI for Queries and generators for consistency
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.2 M7   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords: PII
Depends on:
Blocks:
 
Reported: 2008-10-30 14:26 EDT by Karen Butzke CLA
Modified: 2009-04-30 12:35 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2008-10-30 14:26:43 EDT
Currently Queries section of an Entity there are 2 buttons 'Add...' and 'Add Native...'.  We should change this to just be an 'Add...' button and in the dialog select both a name and a type of query, either 'Named'or Named Native'.  This would follow the pattern for EclipseLink converters where there were 4 types of converters and 4 buttons was overkill. It also lends itself to being more extensible, since there is some potential for adding another kind of query, generator, or converters.

The same thing is true for adding generators on EntityMappings in the orm.xml file.

While cleaning this up I think it makes sense to also remove the Edit buttons from these locations. For sequence generator and table generator the Name widget already exists in the JPA details view when you select a generator.  The edit button just allows you to enter a name.  Queries currently do not have a name widget on the JPA details view, thus the only place you can change the name is in the Edit dialog or in the source.  I think this should be consistent, put the Name widget and remove the Edit button.  This is how the Converters were implemented.
Comment 1 Karen Butzke CLA 2009-04-03 15:27:14 EDT
fixed for 2.2M7
Comment 2 Karen Butzke CLA 2009-04-30 12:35:25 EDT
verified fixed in build I-3.1-20090430071006